feat(collaboration): wire the collaboration UI onto the real backend (#16443)

[mrveiss]

Thinking Path

#16429's triage found ShareSecretDialog.vue depended on useSessionCollaboration.ts, whose other 5 sibling components in components/collaboration/ were themselves unwired — a full real-time collaboration UI (#608 phases 5-7, closed / #874 phase 6) built and never connected. Investigating what backend each composable call actually needed turned up two things: first, useSessionCollaboration.ts was talking entirely to an invented protocol — every message it sent ({type: "session_join", ...}) went over globalWebSocketService's generic /ws/live channel, whose real protocol only understands {action: "subscribe"|"unsubscribe"|"command"|"ping"} (api/live_events.py), so every one of its messages was silently dropped, logged at DEBUG, never delivered. Second, and more surprising: a real, complete backend for this feature already existed and was simply never called — api/collaboration.py's REST API (invite/remove/list-participants/share-secret, backed by a real session_collaborations table with owner/editor/viewer permissions) and websocket/presence.py's PresenceManager (a working join/leave/broadcast WebSocket handler). Tracing that WebSocket's route (api/presence_ws.py) surfaced a live, unauthenticated identity-spoofing vulnerability, fixed separately and urgently in #16455 (merged into this branch so it's self-consistent — GitHub will stop showing those commits here once #16456 lands on Dev_new_gui).

What Changed

• autobot-frontend/src/composables/useSessionCollaboration.ts: rewritten onto the real backend. REST (via new apiService methods: inviteToSession, removeFromSession, shareSecretWithSession, getSessionPresence) for invite/remove/share; a real WebSocket to /ws/sessions/{id}/presence for join/leave presence and a generic {"type":"broadcast","payload"} relay for live activity and secret-share notifications. The composable's public return shape was kept unchanged wherever the real backend could support it.
• autobot-frontend/src/components/collaboration/ParticipantList.vue, PresenceIndicator.vue, ActivityFeed.vue, SecretNotifications.vue: no code changes — each already consumed only the composable's public API, which is why keeping that shape stable mattered.
• autobot-frontend/src/components/collaboration/InviteUserDialog.vue: inviteCollaborator() is now async — added the await its own call site was missing.
• autobot-frontend/src/components/secrets/ShareSecretDialog.vue: shareSecretWithSession() now takes (secretId, participantIds?) and is awaited; the dialog only closes on real success. Dropped the "expires in" selector — Secret.share_with() has no expiry concept at all, so it had zero effect (same class of finding as security(secrets): Visibility/Organization/Team/Shared-With controls in SecretsManager.vue are not enforced server-side #16450).
• autobot-backend/api/collaboration.py: share_secret_with_session now also calls presence_manager.broadcast_to_session() after it commits — connected participants see the share live. Payload carries id/name/sharer only, never the secret's value (pinned by a new test).
• autobot-frontend/src/components/chat/ChatCollaborationPanel.vue (new): a togglable right-side panel, mirroring the existing ChatFilePanel pattern exactly, hosting ParticipantList/ActivityFeed/SecretNotifications with InviteUserDialog as a modal. Wired into ChatInterface.vue's header + right-side panel slot, shown only when session.mode === 'collaborative'.
• autobot-frontend/src/composables/useActivityTracking.ts: retired. Zero real callers; its distinguishing feature (local activity tracking bundled with auto-broadcast) has no current consumer wanting that specific combination — useSessionActivityLogger (the local half) remains independently available to anyone who does.
• i18n: added collaboration.panel.* (title, invite, closePanel, tabParticipants, tabActivity, tabNotifications) with real translations across all 11 locales.

Verification

• pytest api/collaboration_test.py api/presence_ws_auth_16455_test.py api/presence_ws_router_test.py -v → 29 passed, including a new test that pins the secret-share broadcast payload never carries the secret's value.
• New useSessionCollaboration.test.ts: connects to the real presence WS (not /ws/live); a dedicated test asserts nothing this composable sends is ever shaped like one of the 9 old fake message types; presence_sync/user_joined/user_left/user_message(secret_shared|activity) are each exercised against realistic backend payload shapes; invite/share REST calls verified with mocked apiService.
• New ShareSecretDialog.test.ts: confirms the expiry selector is gone, confirms shareSecretWithSession is called with the selected participant ids, confirms the dialog stays open (no shared emit) on a failed share.
• node_modules isn't installed in this environment (pre-push confirms: vue-tsc skipped) — could not run vitest/vue-tsc locally; reasoned through the test files carefully (traced MockWebSocket's connect/readyState timing, i18n string matches, detect-secrets false positives on test fixture data) but CI is the first real execution.
• Found and fixed during implementation: every component calling useSessionCollaboration() registered its own onScopeDispose, unconditionally closing the shared presence socket — harmless while the transport was fake, a real bug now that several components share one real connection. Fixed with reference counting (socket closes only when the last mounted consumer disposes).

Risks

• UserPresence.username falls back to the raw user_id — neither GET .../participants nor the presence WebSocket returns a display name for anyone but the caller. Filed as part of feat(collaboration): persist activity/notification history and add invitation list+respond endpoints #16460.
• Activity feed and secret-share notifications are live-only (no persistence) — a client that reconnects mid-session sees nothing from before it joined. Also feat(collaboration): persist activity/notification history and add invitation list+respond endpoints #16460.
• pendingInvitations/respondToInvitation are removed from the composable entirely (no REST endpoint exists to back them, despite the model already supporting invitations) rather than shipped as a stub. Restored once feat(collaboration): persist activity/notification history and add invitation list+respond endpoints #16460 adds the endpoints.
• This branch currently contains security(collaboration): WS /ws/sessions/{id}/presence trusts an unauthenticated client-supplied user_id #16455's commits (merged in for self-consistency) — expect the diff to shrink once security(collaboration): authenticate and authorize the session-presence WebSocket (#16455) #16456 merges into Dev_new_gui and this branch is rebased/re-merges cleanly.

Model Used

Claude Sonnet 5

Refs #16429 (ShareSecretDialog AC)
Closes #16443

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 9446420e-7547-4902-9c76-a1a70d3af87b

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Notice: 29 open PRs — past the runaway threshold (25)

There is no PR queue limit, and this is not a request to defer this PR. Work proceeds one issue at a time without a cap on open PRs; review capacity is the constraint.

This notice only means the count is high enough to be worth a glance for a runaway — something opening PRs in a loop, or a merge pipeline that has stalled so nothing is draining.

Currently open:

• security(settings): record the real caller on /sync and /hardware-priority, and test the anonymous and cross-org refusals (#16278) #16469 security(settings): record the real caller on /sync and /hardware-priority, and test the anonymous and cross-org refusals (security(settings): the core /api/settings routes read and write system config with no authentication #16278)
• fix(migrations): port 6 orphaned tables into the canonical Alembic chain (#16464) #16467 fix(migrations): port 6 orphaned tables into the canonical Alembic chain (fix(migrations): 6 tables in the orphaned database/migrations/ chain were never applied to the live Alembic chain #16464)
• feat(mcp): admin-configured external MCP server bridge #16458 feat(mcp): admin-configured external MCP server bridge
• security(collaboration): authenticate and authorize the session-presence WebSocket (#16455) #16456 security(collaboration): authenticate and authorize the session-presence WebSocket (security(collaboration): WS /ws/sessions/{id}/presence trusts an unauthenticated client-supplied user_id #16455)
• fix(mcp): rename autobot-backend/mcp/ off the name it shadows (#16449) #16454 fix(mcp): rename autobot-backend/mcp/ off the name it shadows (chore(mcp): autobot-backend/mcp/ shadows the real mcp PyPI SDK, making it unreachable by name #16449)
• feat(secrets): wire in SecretAuditLog, consolidate SecretVault into SecretsManager (#16429) #16453 feat(secrets): wire in SecretAuditLog, consolidate SecretVault into SecretsManager (frontend(secrets): SecretVault, ShareSecretDialog and SecretAuditLog components are unwired #16429)
• docs(adr): supersede ADR-001's fixed VM count with role-separation placement (#15194) #16452 docs(adr): supersede ADR-001's fixed VM count with role-separation placement (docs: a fixed 6-VM topology is documented as the architecture — AutoBot scales from one VM or Docker to whatever is needed, and ADR-001 enshrines the wrong invariant #15194)
• fix(tooling): scope protect-files.sh's secrets/ rule to real credential storage (#16446) #16448 fix(tooling): scope protect-files.sh's secrets/ rule to real credential storage (fix(tooling): protect-files.sh's secrets/ rule blocks legitimate frontend source, zero real targets #16446)
• docs: describe role-based placement instead of a fixed VM count (#15194) #16445 docs: describe role-based placement instead of a fixed VM count (docs: a fixed 6-VM topology is documented as the architecture — AutoBot scales from one VM or Docker to whatever is needed, and ADR-001 enshrines the wrong invariant #15194)
• feat(secrets): bridge connector credential templates to ConnectorCredentialStore (#16428) #16444 feat(secrets): bridge connector credential templates to ConnectorCredentialStore (secrets: connector credential templates must write where knowledge connectors read #16428)
• security(secrets): admin-gate infrastructure hosts, fix vault-backed template names (#16426, #16427) #16442 security(secrets): admin-gate infrastructure hosts, fix vault-backed template names (security(secrets): any logged-in user can list and delete infrastructure hosts through /api/infrastructure/hosts #16426, bug(secrets): the OpenAI and Anthropic quick-add templates save names the vault mirror never recognizes, so the key never reaches the runtime #16427)
• refactor(slm): derive the role list's names, units, health and ports from the role manifests (#16025) #16441 refactor(slm): derive the role list's names, units, health and ports from the role manifests (SLM role shape has two sources of truth: role_registry.DEFAULT_ROLES vs autobot-infrastructure/*/manifest.yml #16025)
• fix(infra): map detect-environment.sh onto files that exist, and drop CONFIGURATION_GUIDE.md's dead env vars (#15143, #15151) #16440 fix(infra): map detect-environment.sh onto files that exist, and drop CONFIGURATION_GUIDE.md's dead env vars (bug(scripts): detect-environment.sh selects three .env files that do not exist #15143, bug(config): AUTOBOT_PLAYWRIGHT_HOST and AUTOBOT_PLAYWRIGHT_API_PORT are documented but read by nothing #15151)
• fix(frontend): point artifact-cells/CodeCell.vue at the shared --codecell-syntax-* tokens (#14853) #16437 fix(frontend): point artifact-cells/CodeCell.vue at the shared --codecell-syntax-* tokens (style(frontend): the two CodeCells now tokenise their syntax palette differently #14853)
• fix(knowledge): wire real grounding:stats counters, replacing the hardcoded claim_sources split (#14981) #16434 fix(knowledge): wire real grounding:stats counters, replacing the hardcoded claim_sources split (bug(knowledge): kb-stats reports a hardcoded claim_sources split — 65/22/13 on an empty KB with zero claims extracted #14981)
• security(auth): fail closed when the password-epoch check cannot reach Redis (#16411) #16433 security(auth): fail closed when the password-epoch check cannot reach Redis (security(backend-auth): password-epoch revocation check fails open when Redis errors (backend equivalent of #16387) #16411)
• chore(slm-frontend): retire getApiUrl(), route its display-only callers through getSlmApiBase() (#15761) #16432 chore(slm-frontend): retire getApiUrl(), route its display-only callers through getSlmApiBase() (tech-debt(slm-frontend): getApiUrl() survived the #13140 migration and still diverges from getSlmApiBase() in DEV #15761)
• chore(frontend): retire useApi.ts, the deprecated useApiWithState composable family (#15025) #16424 chore(frontend): retire useApi.ts, the deprecated useApiWithState composable family (tech-debt(frontend): useApi.ts still exports the deprecated useApiWithState with zero importers — the #7600 migration stopped short of the shim #15025)
• test(voice): judge first audio by chunks released, not a wall-clock race (#16407) #16420 test(voice): judge first audio by chunks released, not a wall-clock race (test(voice): voice_latency_test's streaming-vs-blocking TTFB race looks flaky under CI load (found triaging #16367) #16407)
• fix(security): require sign-in on seven ungated routers, and admin where they change shared state or reach outside (#16375) #16418 fix(security): require sign-in on seven ungated routers, and admin where they change shared state or reach outside (security(api): 44 config-registered routers declare no auth gate, triaged by exposure (found by widening the router-auth guard, #16368) #16375)
• feat(preflight): run every reproducible required check through the workflow's own command (#15933) #16416 feat(preflight): run every reproducible required check through the workflow's own command (Local preflight must cover the 10 required checks #15933)
• fix(guards): fold shell continuations in the hooksPath guard via one shared helper (#15961) #16414 fix(guards): fold shell continuations in the hooksPath guard via one shared helper (core.hooksPath override silently disables every hook in a worktree #15961)
• fix(security): deny an SLM token when its revocation check cannot run, HS256 and RS256 (#16387, #16412) #16413 fix(security): deny an SLM token when its revocation check cannot run, HS256 and RS256 (security(slm-auth): token revocation checks fail open when Redis errors, so a revoked token is accepted #16387, security(slm-auth): RS256 authority-token revocation check fails open when Redis errors #16412)
• fix(security): generate the vault root key from 32 random bytes, not alphanumeric characters (#16405) #16410 fix(security): generate the vault root key from 32 random bytes, not alphanumeric characters (security(secrets): the vault root key is base64 of 32 alphanumeric chars (~190 bits), not 32 random bytes #16405)
• chore(docker): retire the four agent Dockerfiles whose modules no longer exist; agents run in-process (#16361) #16409 chore(docker): retire the four agent Dockerfiles whose modules no longer exist; agents run in-process (chore(docker): four agent Dockerfiles under autobot-infrastructure/autobot-backend/docker/ are built by nothing: wire in or retire #16361)
• chore(deps): carry dependabot's npm security bumps onto Dev_new_gui (hono 4.13.7 and transitive; supersedes #16171) #16408 chore(deps): carry dependabot's npm security bumps onto Dev_new_gui (hono 4.13.7 and transitive; supersedes chore(deps): bump the npm_and_yarn group across 6 directories with 7 updates #16171)
• fix(tests): stop gating a disk-bound model load on a CPU work budget, and prove it stays offline and import-free (#15055, #15235) #16404 fix(tests): stop gating a disk-bound model load on a CPU work budget, and prove it stays offline and import-free (test(perf): startup benchmarks assert absolute wall-clock budgets and fail on runner load — passed and failed on the same code minutes apart #15055, test(perf): three calibrated budgets are drifting or disk-bound — the startup margin is 1.4x, not the 1.9x its note records #15235)
• fix(ci): keep the drift-checked SLM agent mirror out of the duplication scan (#16401) #16402 fix(ci): keep the drift-checked SLM agent mirror out of the duplication scan (ci(duplication-guard): the SLM scope counts the drift-checked agent mirror, so every agent change fails the absolute pin #16401)
• fix(ci): bring CI's pytest environment up to its declared floors, and gate on them (#16264) #16391 fix(ci): bring CI's pytest environment up to its declared floors, and gate on them (ci: the pytest environment sits below two declared floors, and the floor banner tells CI readers the opposite #16264)

If the queue is draining normally, ignore this. Otherwise:

1. Check whether CI is dispatching at all — see the ci-dispatch-watchdog status on these PRs
2. Merge the ones whose CI has finished and review has passed: gh pr merge <number> --squash --delete-branch
3. Look for a loop opening near-identical PRs

Warn-only runaway detector — .github/workflows/pr-queue-gate.yml. It never blocks a merge.

[github-actions]

✅ SSOT Configuration Compliance: Passing

🎉 No new hardcoded values of either class — ssot and other both block.

Known backlog in pipeline-scripts/hardcoded_values_baseline.txt is suppressed and tracked in #14371.

[mrveiss]

Bug in this head's own commit fixed in the 2d vehicle: #16702, commit 3a13531.

SecretsManager.vue:238 called shareSecret(secret) — secret isn't in scope in that block (the v-for binds item, and every sibling action button uses item.data). Caught by vue-tsc-baseline on the combined vehicle tree (introduced at 1c48732). Fixed to shareSecret(item.data); this PR's own branch was never updated. Per the merge-train plan this PR merges pinned to its current head and the vehicle lands immediately after with the fix — no action needed on this branch.