Skip to content

Conversation

@brizental
Copy link
Contributor

@brizental brizental commented Jul 20, 2021

Blocked until mozilla/glean.js#542 makes it into a release. This feature was released in v0.18.0.

Filed a bug to also add docs about the RLB shutdown API: https://bugzilla.mozilla.org/show_bug.cgi?id=1721388

@brizental brizental force-pushed the 1707891-shutdown-docs branch from 9c3a741 to d29c75f Compare July 22, 2021 15:52
@brizental brizental marked this pull request as ready for review July 22, 2021 15:52
@auto-assign auto-assign bot requested a review from travis79 July 22, 2021 15:52
@brizental brizental removed the blocked Blocked pull requests and issues label Jul 22, 2021
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a handful of uber-nits related to commas, no need to block on landing this, or re-review. Looks good!

Co-authored-by: Travis Long <tlong@mozilla.com>
@brizental brizental merged commit e5b82ad into mozilla:main Jul 26, 2021
@brizental brizental deleted the 1707891-shutdown-docs branch July 26, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants