Bug 1707891 - Do not clear deletion-request pings when clearing pings queue #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that in rally-core a bunch of pings are sent before the deletion-request. It takes a while for the upload to finish. setUploadDisabled will clear the pings queue before they can complete sending all pings,including the deletion-request. Note: At this point the test fails.
Additionaly this changes the behaviour of the Clear command to return the Dispatcher to an Idle state after clearing instead of returning it to a Stopped state. That behaviour was rather arbitrary from the start and apart from some necessary test changes, it does not change Glean's behaviour.'
travis79
approved these changes
Jul 22, 2021
Member
travis79
left a comment
travis79
left a comment
There was a problem hiding this comment.
This LGTM, good job catching this early and fixing it quickly!
|
|
||
| post(url: string, body: string): Promise<UploadResult> { | ||
| async post(url: string, body: string): Promise<UploadResult> { | ||
| // Make this a tiny bit slow to mimic reality a bit better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lint && npm run lint:circular-depsRuns all lintersCHANGELOG.mdor an explanation of why it does not need one