Bug 1707891 - Implement shutdown API #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
force-pushed
the
1707891-shutdown
branch
from
387a1ec to
e76c749
Compare
This is a long overdue refactoring i.e. it should have been done when we implemented the dispatcher. The PingUploader had sort of a mini dispatcher implementation in it, it would be silly to implement shutdown for this alternate dispatcher in this PR so I decided to finally refactor it to use the same dispatcher. The actual Dispatcher class is much more robust as well, it was implemeted after the Uploader and a lot of thought has gone into it. I trust it more than the mini dispatcher we used to have inside the PingUploader.
brizental
force-pushed
the
1707891-shutdown
branch
from
e76c749 to
d6155ea
Compare
travis79
approved these changes
Jul 20, 2021
Member
travis79
left a comment
travis79
left a comment
There was a problem hiding this comment.
This looks really good to me! Mostly just some grammar and clarification nits.
Co-authored-by: Travis Long <tlong@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of this API causes a bug in Rally. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1698934#c33
Note
I have confirmed that this fixes the issue and makes the test over on mozilla-rally/rally-core-addon#678 pass.
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lint && npm run lint:circular-depsRuns all lintersCHANGELOG.mdor an explanation of why it does not need one