add few fields to CITP pioneer study schema #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreid-moz
approved these changes
Oct 30, 2020
Contributor
mreid-moz
left a comment
mreid-moz
left a comment
There was a problem hiding this comment.
Looks good to me. Tagging @acmiyaguchi to take a look next week in case I missed something.
|
Thank you so much @mreid-moz!!! |
jklukas
pushed a commit
that referenced
this pull request
Nov 2, 2020
7b15df7 2020-10-30 18:09:50 +0000 add few fields to CITP pioneer study schema (#635) 0d2262b 2020-10-29 12:52:37 -0700 Updates for CITP Pioneer study schema (#634) dda5d19 2020-10-22 17:37:57 -0700 Add schema for CITP's Pioneer study (#632) 7ad71b3 2020-10-16 14:27:09 -0400 Add fissionEnabled to new uninstall ping (#631) 0f34b31 2020-10-16 14:04:03 -0400 Bug 1461690 - Add Uninstall Telemetry ping schema (#629) a48ef97 2020-10-13 21:27:37 +0200 Bug 1669208 - Add fissionEnabled field to environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this is the last of our changes for a little while 😬
Checklist for reviewer:
.circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logsintegrationCI test by pushing this revision as discussed in the README and review the report posted in the comments.For glean changes:
templates/include/glean/CHANGELOG.md