Skip to content

Conversation

@agashlin
Copy link
Contributor

@agashlin agashlin commented Oct 9, 2020

Checklist for reviewer:

  • Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title)
  • Scan the PR and verify that no changes (particularly to .circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logs
  • If the PR comes from a fork, trigger the integration CI test by pushing this revision as discussed in the README and review the report posted in the comments.

For glean changes:

  • Update templates/include/glean/CHANGELOG.md

@jklukas jklukas self-requested a review October 16, 2020 17:28
Copy link
Contributor

@jklukas jklukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge once integration tests are complete.

@jklukas jklukas merged commit 0f34b31 into mozilla-services:master Oct 16, 2020
jklukas added a commit that referenced this pull request Oct 16, 2020
I think this is a weird ordering problem where the tests succeeded on
#629
but after merging, it was out of date with the new fissionEnabled field.
jklukas added a commit that referenced this pull request Oct 16, 2020
I think this is a weird ordering problem where the tests succeeded on
#629
but after merging, it was out of date with the new fissionEnabled field.
dataops-pipeline-schemas added a commit that referenced this pull request Oct 19, 2020
7ad71b3	2020-10-16 14:27:09 -0400	Add fissionEnabled to new uninstall ping (#631)
0f34b31	2020-10-16 14:04:03 -0400	Bug 1461690 - Add Uninstall Telemetry ping schema (#629)
JoyLubega pushed a commit to JoyLubega/mozilla-pipeline-schemas that referenced this pull request Oct 29, 2020
dda5d19	2020-10-22 17:37:57 -0700	Add schema for CITP's Pioneer study (mozilla-services#632)
7ad71b3	2020-10-16 14:27:09 -0400	Add fissionEnabled to new uninstall ping (mozilla-services#631)
0f34b31	2020-10-16 14:04:03 -0400	Bug 1461690 - Add Uninstall Telemetry ping schema (mozilla-services#629)
a48ef97	2020-10-13 21:27:37 +0200	Bug 1669208 - Add fissionEnabled field to environment
jklukas pushed a commit that referenced this pull request Nov 2, 2020
7b15df7	2020-10-30 18:09:50 +0000	add few fields to CITP pioneer study schema (#635)
0d2262b	2020-10-29 12:52:37 -0700	Updates for CITP Pioneer study schema (#634)
dda5d19	2020-10-22 17:37:57 -0700	Add schema for CITP's Pioneer study (#632)
7ad71b3	2020-10-16 14:27:09 -0400	Add fissionEnabled to new uninstall ping (#631)
0f34b31	2020-10-16 14:04:03 -0400	Bug 1461690 - Add Uninstall Telemetry ping schema (#629)
a48ef97	2020-10-13 21:27:37 +0200	Bug 1669208 - Add fissionEnabled field to environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants