Updates for CITP Pioneer study schema #634
Conversation
acmiyaguchi
left a comment
acmiyaguchi
left a comment
There was a problem hiding this comment.
Hi @akohlbre, could you rebase this PR onto the latest version of mozilla-pipeline-schemas. Make sure the main repo is set as a remote (e.g. upstream) and rebase the new patches onto the main branch. It should be something like the following:
git rebase --onto upstream/master HEAD~2
| "type": "object" | ||
| }, | ||
| "WebScience.SurveyId": { | ||
| "type": "string" |
There was a problem hiding this comment.
It's good practice to document the use of this field using the description property, which will get inserted into the BigQuery schema.
| "other" | ||
| ], | ||
| "type": "string" | ||
| "type": "integer" |
There was a problem hiding this comment.
This type change won't play well with automated checks in our deployment pipeline. There are two ways to change this. The first is document this field as deprecated in a description and to add a new property (e.g. pageClassification) which would be evolution compatible. The other is to copy the schema with the version bumped.
|
Alright --
Oops, sorry, I totally forgot to grab updates. Think I got the rebase to work, thanks.
Added a description for the survey ID field.
Added the old field back and labeled it deprecated, and used your suggested name for the replacement. Thanks! |
|
Looks good to me. |
7b15df7 2020-10-30 18:09:50 +0000 add few fields to CITP pioneer study schema (#635) 0d2262b 2020-10-29 12:52:37 -0700 Updates for CITP Pioneer study schema (#634) dda5d19 2020-10-22 17:37:57 -0700 Add schema for CITP's Pioneer study (#632) 7ad71b3 2020-10-16 14:27:09 -0400 Add fissionEnabled to new uninstall ping (#631) 0f34b31 2020-10-16 14:04:03 -0400 Bug 1461690 - Add Uninstall Telemetry ping schema (#629) a48ef97 2020-10-13 21:27:37 +0200 Bug 1669208 - Add fissionEnabled field to environment
3 participants
Main changes are two new fields added to the schema (also removed overly-aggressive validation).
Checklist for reviewer:
.circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logsintegrationCI test by pushing this revision as discussed in the README and review the report posted in the comments.For glean changes:
templates/include/glean/CHANGELOG.md