[ros-o] rely on post-noetic pybind11_catkin#733
Merged
v4hn merged 1 commit intomoveit:masterfrom Dec 12, 2025
Merged
Conversation
ros-o's pybind11_catkin bundles a sufficient pybind11 and ensures python_add_library is available also with ros-o catkin, where the implicit `find_package(Python COMPONENTS Interpreter)` does not provide it by default anymore.
d2f62b1 to
7854365
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #733 +/- ##
=======================================
Coverage 52.86% 52.86%
=======================================
Files 138 138
Lines 10630 10630
Branches 1128 1128
=======================================
Hits 5618 5618
Misses 5004 5004
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ros-o's pybind11_catkin bundles a sufficient pybind11 and ensures
python_add_libraryis available also with the ros-o transition tofind_package(Python COMPONENTS Interpreter)in catkin, which does not provide it by default anymore.