Port kinematics_plugin_loader to ROS2 - #107
Merged
henningkayser merged 4 commits intoDec 6, 2019
Merged
Conversation
JafarAbdi
force-pushed
the
pr-kinematics_plugin_loader
branch
from
October 21, 2019 18:47
54efef9 to
5fe0795
Compare
JafarAbdi
force-pushed
the
pr-kinematics_plugin_loader
branch
from
October 27, 2019 08:05
06cfbca to
449cff2
Compare
Member
Author
|
This PR depends on PR#104 |
| std::string ksolver_param_name; | ||
| bool found = nh.searchParam(base_param_name + "/kinematics_solver", ksolver_param_name); | ||
| if (!found || !nh.hasParam(ksolver_param_name)) | ||
| std::string ksolver_param_name = base_param_name + "/kinematics_solver"; |
Member
There was a problem hiding this comment.
This whole part seems overly complicated to me (it already was in the original implementation). But it's probably not the point for premature optimization here. Could you add a TODO: revise parameter lookup here so we can track what parameters we need to test/improve in the future?
Member
Author
Member
There was a problem hiding this comment.
I think the yaml you linked doesn't belong to the cpp file. What they did is use dynamic_reconfigure to generate the parameters: https://github.com/ros-planning/navigation2/blob/6bfa8c48ea0291fff540eb7aead6e5e511130bd7/nav2_costmap_2d/cfg/ObstaclePlugin.cfg. Normal parameters use forward slashes as namespace separators, at least I didn't find anything that supports something else: https://design.ros2.org/articles/ros_parameters.html https://design.ros2.org/articles/topic_and_service_names.html.
nbbrooks
force-pushed
the
pr-kinematics_plugin_loader
branch
from
December 6, 2019 21:32
c0dbc56 to
7dd5db7
Compare
henningkayser
left a comment
henningkayser
left a comment
Member
There was a problem hiding this comment.
Looks good! Just some minor changes, then lgtm
- Update CMakeLists.txt - Update parameter resolution - Update logger
henningkayser
force-pushed
the
pr-kinematics_plugin_loader
branch
from
December 6, 2019 22:35
7dd5db7 to
3e4e9e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of PR#74
I did the same as in this PR#104 for applying the changes