Skip to content

Conversation

@tsbinns
Copy link
Contributor

@tsbinns tsbinns commented Jan 24, 2026

Reference issue (if any)

Fixes #13608

What does this implement/fix?

Remove pre-commit call in SPEC0 action that caused it to fail when updates to minimum versions were made.

@tsbinns tsbinns requested a review from larsoner as a code owner January 24, 2026 17:47
@tsbinns tsbinns changed the title Remove pre-commit call [ci skip] Remove pre-commit call in SPEC0 action Jan 24, 2026
- name: Run pre-commit hooks to update other files
run: |
pip install pre-commit
pre-commit run --all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore with || true?

And if you add pr: to the on: block above we can see it make an attempt here, then remove, then merge, then trigger on main with workflow_dispatch

@tsbinns tsbinns changed the title Remove pre-commit call in SPEC0 action Fix pre-commit call in SPEC0 action Jan 26, 2026
@tsbinns
Copy link
Contributor Author

tsbinns commented Jan 26, 2026

@larsoner, yeah the || true got it to the PR stage. Have removed the on-pr, so should be good to go?

@larsoner larsoner merged commit 1300eae into mne-tools:main Jan 26, 2026
2 of 4 checks passed
@tsbinns tsbinns deleted the fix_speczero branch January 26, 2026 19:41
larsoner added a commit to teonbrooks/mne-python that referenced this pull request Jan 30, 2026
* upstream/main: (23 commits)
  DOC: Add jupyterlite idea to roadmap (mne-tools#13620)
  MAINT: Use f-strings in test_import_nesting.py (mne-tools#13551)
  Improve docs for raw.to_data_frame (mne-tools#13590)
  Sensitivity map doc improved (mne-tools#13578)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13612)
  MAINT: Fix for latest SciPy (mne-tools#13613)
  Fix pre-commit call in SPEC0 action [ci skip] (mne-tools#13609)
  MAINT: Add mne-denoise to CI dependencies (mne-tools#13607)
  FIX: do not cache canvas object (mne-tools#13606)
  FIX: Set calibration plot axes to screen resolution if available (mne-tools#13558)
  Refactoring eyetracking.py (mne-tools#13602)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13601)
  Follow up PR to PR - mne-tools#13596 (mne-tools#13599)
  FIX: Sphinx (mne-tools#13600)
  Doc improvement - Examples using <some-method> section quirk fix (mne-tools#13596)
  Add more information to eSSS in examples and docsstring (mne-tools#13591)
  np.fix -> np.trunc (deprecation) (mne-tools#13594)
  Make mne.sys_info() work with powershell 7+ (mne-tools#13593)
  BUG: Fix minor bug with T1 check (mne-tools#13588)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13587)
  ...
larsoner added a commit to contsili/mne-python that referenced this pull request Jan 30, 2026
* upstream/main: (67 commits)
  DOC: Add jupyterlite idea to roadmap (mne-tools#13620)
  MAINT: Use f-strings in test_import_nesting.py (mne-tools#13551)
  Improve docs for raw.to_data_frame (mne-tools#13590)
  Sensitivity map doc improved (mne-tools#13578)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13612)
  MAINT: Fix for latest SciPy (mne-tools#13613)
  Fix pre-commit call in SPEC0 action [ci skip] (mne-tools#13609)
  MAINT: Add mne-denoise to CI dependencies (mne-tools#13607)
  FIX: do not cache canvas object (mne-tools#13606)
  FIX: Set calibration plot axes to screen resolution if available (mne-tools#13558)
  Refactoring eyetracking.py (mne-tools#13602)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13601)
  Follow up PR to PR - mne-tools#13596 (mne-tools#13599)
  FIX: Sphinx (mne-tools#13600)
  Doc improvement - Examples using <some-method> section quirk fix (mne-tools#13596)
  Add more information to eSSS in examples and docsstring (mne-tools#13591)
  np.fix -> np.trunc (deprecation) (mne-tools#13594)
  Make mne.sys_info() work with powershell 7+ (mne-tools#13593)
  BUG: Fix minor bug with T1 check (mne-tools#13588)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13587)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SPEC0 action failing to reach PR

2 participants