Skip to content

SPEC0 action failing to reach PR #13608

@tsbinns

Description

@tsbinns

This week our SPEC0-like rules should have updated several minimum dependency versions, but the workflow failed to produce a PR: https://github.com/mne-tools/mne-python/actions/runs/21123144706/job/60739270331

I can replicate this locally that pyproject.toml gets updated as expected, but when the pre-commit hook update-env-file is run (copying the changes to environment.yml), the hook fails because it does introduce changes to environment.yml. Therefore the action errors out before the PR can be created.

I question whether we need to call pre-commit prior to creating the PR. It is enough to update pyproject.toml, open the PR, then let the pre-commit PR action auto-fix copying the changes to environment.yml.

The pre-commit call was added in #13534, and I think this is the first time the SPEC0 action has had a minimum version to update since then.

Metadata

Metadata

Assignees

No one assigned

    Labels

    github_actionsPull requests that update GitHub Actions code

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions