Skip to content

Fix pre-commit call in SPEC0 action #13609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsoner merged 6 commits into from
Jan 26, 2026
+2 −1
Merged

Fix pre-commit call in SPEC0 action #13609

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8517e0b
Remove pre-commit call [ci skip]
tsbinns Jan 24, 2026
91d7e93
Restore with true
tsbinns Jan 26, 2026
d125cab
Remove on-pr [ci skip]
tsbinns Jan 26, 2026
e4b98b3
Add conditional to pre-commit check [ci skip]
tsbinns Jan 26, 2026
aa9574f
Apply suggestion from @larsoner [ci skip]
larsoner Jan 26, 2026
f28c8e8
Better place [ci skip]
larsoner Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/spec_zero.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,12 @@ jobs:
- name: Run pre-commit hooks to update other files
run: |
pip install pre-commit
pre-commit run --all
Copy link
Member

@larsoner larsoner Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore with || true?

And if you add pr: to the on: block above we can see it make an attempt here, then remove, then merge, then trigger on main with workflow_dispatch

pre-commit run --all || true
if: steps.status.outputs.dirty == 'true'
- name: Create PR
run: |
set -xeo pipefail
git diff
git config --global user.email "50266005+mne-bot@users.noreply.github.com"
git config --global user.name "mne[bot]"
git checkout -b spec_zero
Expand Down
Loading