Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remove collection queryable check from health check #37712

Conversation

jaime0815
Copy link
Contributor

No description provided.

Signed-off-by: jaime <yun.zhang@zilliz.com>
@jaime0815 jaime0815 added this to the 2.5.0 milestone Nov 15, 2024
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 15, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.67%. Comparing base (caf207f) to head (00780a6).
Report is 37 commits behind head on master.

Files with missing lines Patch % Lines
internal/querycoordv2/services.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37712       +/-   ##
===========================================
+ Coverage   68.07%   80.67%   +12.60%     
===========================================
  Files         290     1357     +1067     
  Lines       25455   190680   +165225     
===========================================
+ Hits        17328   153830   +136502     
- Misses       8127    31417    +23290     
- Partials        0     5433     +5433     
Components Coverage Δ
Client 61.25% <ø> (∅)
Core 68.92% <ø> (+0.84%) ⬆️
Go 83.18% <0.00%> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/services.go 87.07% <0.00%> (ø)

... and 1075 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 15, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Nov 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 257ecab into milvus-io:master Nov 18, 2024
19 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Nov 18, 2024
@jaime0815 jaime0815 deleted the remove-collection-queryable-from-health-check branch November 18, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants