Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remove collection queryable check from health check #37731

Conversation

jaime0815
Copy link
Contributor

pr: #37712

Signed-off-by: jaime <yun.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 15, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.31%. Comparing base (cdf703a) to head (fc2ea5c).
Report is 3 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querycoordv2/services.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37731      +/-   ##
==========================================
- Coverage   80.65%   72.31%   -8.34%     
==========================================
  Files        1069     1069              
  Lines      166900   166900              
==========================================
- Hits       134605   120686   -13919     
- Misses      27902    41820   +13918     
- Partials     4393     4394       +1     
Files with missing lines Coverage Δ
internal/querycoordv2/services.go 85.29% <0.00%> (ø)

... and 226 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Nov 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3ce27ca into milvus-io:2.4 Nov 18, 2024
13 of 15 checks passed
@jaime0815 jaime0815 deleted the remove-collection-queryable-from-health-check-24 branch November 18, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants