Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remove collection queryable check from health check #37712

Merged
merged 1 commit into from
Nov 18, 2024
Merged

enhance: remove collection queryable check from health check #37712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
enhance: remove collection queryable check from health check 
Signed-off-by: jaime <yun.zhang@zilliz.com>
  • Loading branch information
@jaime0815
jaime0815 committed Nov 15, 2024
commit 00780a6a8febd08d5869f291357b599ef83a68f7
2 changes: 1 addition & 1 deletion internal/querycoordv2/services.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@
}

if err := utils.CheckCollectionsQueryable(ctx, s.meta, s.targetMgr, s.dist, s.nodeMgr); err != nil {
return componentutil.CheckHealthRespWithErr(err), nil
log.Warn("some collection is not queryable during health check", zap.Error(err))

Check warning on line 927 in internal/querycoordv2/services.go

View check run for this annotation

Codecov / codecov/patch

internal/querycoordv2/services.go#L927 

Added line #L927 was not covered by tests
}

return componentutil.CheckHealthRespWithErr(nil), nil
Expand Down
Loading