Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.3] init the hook when creating the proxy object #34936

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 23, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

Signed-off-by: SimFG <bang.fu@zilliz.com>
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.15%. Comparing base (a5deaa1) to head (9ae5220).
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #34936      +/-   ##
==========================================
+ Coverage   83.07%   83.15%   +0.08%     
==========================================
  Files         852      852              
  Lines      107744   107232     -512     
==========================================
- Hits        89507    89174     -333     
+ Misses      14928    14741     -187     
- Partials     3309     3317       +8     
Files Coverage Δ
internal/proxy/hook_interceptor.go 80.85% <100.00%> (+2.95%) ⬆️
internal/querycoordv2/utils/util.go 100.00% <ø> (ø)
internal/proxy/proxy.go 69.08% <0.00%> (-0.81%) ⬇️

... and 78 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jul 24, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jul 24, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jul 24, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit fe786ff into milvus-io:2.3 Jul 24, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants