-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: [2.3] init the hook when creating the proxy object #34936
Conversation
SimFG
commented
Jul 23, 2024
- issue: [Bug]: proxy auth interceptor may fail in first few search requests due to hook initialization logic #34885
- pr: fix: Unify hook singleton implementation in proxy #34887
/lgtm |
Signed-off-by: SimFG <bang.fu@zilliz.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #34936 +/- ##
==========================================
+ Coverage 83.07% 83.15% +0.08%
==========================================
Files 852 852
Lines 107744 107232 -512
==========================================
- Hits 89507 89174 -333
+ Misses 14928 14741 -187
- Partials 3309 3317 +8
|
@SimFG E2e jenkins job failed, comment |
/run-cpu-e2e |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SimFG, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |