Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unify hook singleton implementation in proxy #34887

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

congqixia
Copy link
Contributor

Related to #34885

Related to milvus-io#34885

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Jul 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 22, 2024
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.87%. Comparing base (c339df2) to head (d808367).
Report is 39 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34887      +/-   ##
==========================================
- Coverage   80.84%   71.87%   -8.98%     
==========================================
  Files        1175     1185      +10     
  Lines      142066   142718     +652     
==========================================
- Hits       114854   102576   -12278     
- Misses      22822    35729   +12907     
- Partials     4390     4413      +23     
Files Coverage Δ
internal/proxy/hook_interceptor.go 100.00% <100.00%> (ø)
internal/proxy/impl.go 86.25% <100.00%> (ø)
internal/proxy/proxy.go 70.34% <100.00%> (-0.12%) ⬇️
internal/proxy/util.go 91.65% <100.00%> (-0.01%) ⬇️
internal/util/hookutil/default.go 100.00% <ø> (ø)
tests/integration/minicluster_v2.go 72.72% <100.00%> (ø)
internal/util/hookutil/hook.go 50.81% <54.54%> (+4.15%) ⬆️

... and 268 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jul 23, 2024
sre-ci-robot pushed a commit that referenced this pull request Jul 24, 2024
- issue: #34885
- pr: #34887

Signed-off-by: SimFG <bang.fu@zilliz.com>
@aoiasd
Copy link
Contributor

aoiasd commented Jul 26, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 783f9d9 into milvus-io:master Jul 26, 2024
9 of 12 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jul 26, 2024
Cherry-pick from master
pr: #34887
Related to #34885

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia deleted the fix/unify_hook_singleton branch July 30, 2024 07:51
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
Related to milvus-io#34885

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants