-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Unify hook singleton implementation in proxy #34887
fix: Unify hook singleton implementation in proxy #34887
Conversation
Related to milvus-io#34885 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34887 +/- ##
==========================================
- Coverage 80.84% 71.87% -8.98%
==========================================
Files 1175 1185 +10
Lines 142066 142718 +652
==========================================
- Hits 114854 102576 -12278
- Misses 22822 35729 +12907
- Partials 4390 4413 +23
|
/lgtm |
Related to milvus-io#34885 --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com> Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Related to #34885