Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: proxy auth interceptor may fail in first few search requests due to hook initialization logic #34885

Closed
1 task done
congqixia opened this issue Jul 22, 2024 · 0 comments
Closed
1 task done

[Bug]: proxy auth interceptor may fail in first few search requests due to hook initialization logic #34885

congqixia opened this issue Jul 22, 2024 · 0 comments
Assignees
@congqixia
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: master@52fa668 & v2.4.6
- Deployment mode(standalone or cluster): both
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

proxy auth interceptor may fail in first few search request due to hook initialization logic
this is a false alarm since no error will returned after lazy initialization in HookInterceptor

Expected Behavior

No transient error in first few requests

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@congqixia congqixia added kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jul 22, 2024
@congqixia congqixia self-assigned this Jul 22, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Jul 22, 2024
@congqixia
fix: Unify hook singleton implementation in proxy
2d79381 
Related to milvus-io#34885

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jul 22, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Jul 22, 2024
@congqixia
fix: Unify hook singleton implementation in proxy
ebb1b5a 
Related to milvus-io#34885

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue Jul 22, 2024
Merged
@SimFG SimFG mentioned this issue Jul 23, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jul 24, 2024
@SimFG
enhance: [2.3] init the hook when creating the proxy object (#34936)
fe786ff 
- issue: #34885
- pr: #34887

Signed-off-by: SimFG <bang.fu@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jul 26, 2024
@congqixia
fix: Unify hook singleton implementation in proxy (#34887)
783f9d9 
Related to #34885

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Jul 26, 2024
@congqixia
fix: [2.4] Unify hook singleton implementation in proxy (#34888)
079276c 
Cherry-pick from master
pr: #34887
Related to #34885

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sumitd2 pushed a commit to sumitd2/milvus that referenced this issue Aug 6, 2024
@congqixia @sumitd2
fix: Unify hook singleton implementation in proxy (milvus-io#34887)
5d78f98 
Related to milvus-io#34885

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@congqixia