Forward-port insertion pipeline and System.Memory bump from rel/18.7#15716
Merged
Conversation
The insertion pipeline on rel/18.7 went through several rounds of fixing (microsoft#15698, microsoft#15700-microsoft#15708) and ended up working. Main still has the pre-iteration shape, which would mean the next release branch cut from main inherits a broken pipeline. Also bump System.Memory 4.5.5 -> 4.6.3 to match rel/18.7 (microsoft#15706).
Contributor
There was a problem hiding this comment.
Pull request overview
Forward-ports fixes from rel/18.7 to keep the VS insertion pipeline working when the next release branch is cut from main, and updates a dependency version used by the build.
Changes:
- Bump
System.Memoryversion ineng/Versions.propsfrom 4.5.5 to 4.6.3. - Rework
azure-pipelines-insertion.ymlto install the .NET SDK fromglobal.jsonand adjust the VS insertion invocation (Roslyn tools install + updated args/flags).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| eng/Versions.props | Updates the SystemMemoryVersion property to 4.6.3. |
| azure-pipelines-insertion.yml | Updates insertion pipeline steps for SDK installation and Roslyn insertion tooling/arguments. |
…et, fix whitespace/comment - Get-Content -Raw so multi-line JSON parses - Use globalJson.sdk.version (canonical) instead of tools.dotnet - Invoke dotnet from $(Build.SourcesDirectory)\.dotnet\dotnet.exe so tool install uses the freshly installed SDK, not the agent's preinstalled one - Fix comment referring to --tools-install (command uses --tool-path) - Strip trailing whitespace
nohwnd
added
the
🚢 Ship it!
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port from rel/18.7:
azure-pipelines-insertion.yml— rel/18.7 got several rounds of fixes (Fix insertion pipeline to install .NET SDK from global.json #15698, Update .NET SDK installation script to install sdk #15700-Fix vs insertion script #15708) to make VS insertion work. Main still has the pre-fix version, next rel/ branched from main would be broken again.