Skip to content

[rel/18.7] Fix insertion pipeline: read sdk.version, use installed dotnet, trim whitespace#15717

Merged
nohwnd merged 1 commit into
microsoft:rel/18.7from
nohwnd:fix-insertion-pipeline-review-rel-18.7
Apr 23, 2026
Merged

[rel/18.7] Fix insertion pipeline: read sdk.version, use installed dotnet, trim whitespace#15717
nohwnd merged 1 commit into
microsoft:rel/18.7from
nohwnd:fix-insertion-pipeline-review-rel-18.7

Conversation

@nohwnd

@nohwnd nohwnd commented Apr 22, 2026

Copy link
Copy Markdown
Member

Apply the same review fixes from #15716 to rel/18.7, since the pipeline there has the same issues.

  • Get-Content -Raw so multi-line global.json parses
  • Read $globalJson.sdk.version instead of tools.dotnet
  • Invoke dotnet from the freshly installed .dotnet\dotnet.exe so tool install doesn't use the agent's preinstalled SDK
  • Fix --tools-install comment (command uses --tool-path)
  • Strip trailing whitespace

…whitespace

- Get-Content -Raw so multi-line global.json parses

- Use globalJson.sdk.version instead of tools.dotnet

- Invoke dotnet from $(Build.SourcesDirectory)\.dotnet\dotnet.exe so tool install uses the freshly installed SDK, not the agent's preinstalled one

- Fix comment referring to --tools-install (command uses --tool-path)

- Strip trailing whitespace
@nohwnd nohwnd added the 🚢 Ship it! Add to PRs where owner approves automated PR, but cannot approve because they "wrote it". label Apr 22, 2026
@nohwnd nohwnd enabled auto-merge (squash) April 22, 2026 21:03
@nohwnd nohwnd disabled auto-merge April 23, 2026 05:52
@nohwnd nohwnd merged commit 22e6b8e into microsoft:rel/18.7 Apr 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚢 Ship it! Add to PRs where owner approves automated PR, but cannot approve because they "wrote it".

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant