Skip to content

Fix insertion pipeline to install .NET SDK from global.json#15698

Merged
nohwnd merged 1 commit into
microsoft:rel/18.7from
nohwnd:fix-insertion-sdk-rel-18.7
Apr 20, 2026
Merged

Fix insertion pipeline to install .NET SDK from global.json#15698
nohwnd merged 1 commit into
microsoft:rel/18.7from
nohwnd:fix-insertion-sdk-rel-18.7

Conversation

@nohwnd

@nohwnd nohwnd commented Apr 20, 2026

Copy link
Copy Markdown
Member

The insertion pipeline was using -version 'Latest' which installs the latest stable public SDK (e.g. .NET 10), not the .NET 11 preview pinned in global.json.

This changes the step to read tools.dotnet from global.json and pass that specific version to dotnet-install.ps1, ensuring the correct .NET 11 preview SDK is installed.

Build: https://dnceng.visualstudio.com/internal/_build/results?buildId=2955568&view=results

The insertion pipeline was using `-version 'Latest'` which installs the
latest stable public SDK (.NET 10), not the .NET 11 preview SDK pinned
in global.json. Read `tools.dotnet` from global.json so the correct
preview SDK is installed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@nohwnd nohwnd merged commit ef816ac into microsoft:rel/18.7 Apr 20, 2026
3 checks passed
nohwnd added a commit that referenced this pull request Apr 23, 2026
…15716)

* Forward-port insertion pipeline and System.Memory bump from rel/18.7

The insertion pipeline on rel/18.7 went through several rounds of fixing (#15698, #15700-#15708) and ended up working. Main still has the pre-iteration shape, which would mean the next release branch cut from main inherits a broken pipeline.

Also bump System.Memory 4.5.5 -> 4.6.3 to match rel/18.7 (#15706).

* Address review: read SDK version from sdk.version, use installed dotnet, fix whitespace/comment

- Get-Content -Raw so multi-line JSON parses

- Use globalJson.sdk.version (canonical) instead of tools.dotnet

- Invoke dotnet from $(Build.SourcesDirectory)\.dotnet\dotnet.exe so tool install uses the freshly installed SDK, not the agent's preinstalled one

- Fix comment referring to --tools-install (command uses --tool-path)

- Strip trailing whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant