Conversation
a9c8e3c to
4a7ba33
Compare
|
@microsoft-github-policy-service agree |
|
My 2 cents here: I understand that Institute of Standards and Industrial Research translated keys like "Control" to "مهار", but in my personal experience I haven't seen any adaptation of these translations in any Persian app. I'm pretty sure people will be confused of that translation, and the same doc ISIRI-9147.pdf used the word "کنترل" multiple times all over the document. That said, I do believe that "مهار" is a more beautiful word and maybe this is where its adaptation can begin (: The alternative would be to just not translate it and leave it as is, just like how "LF" and "UTF-8" are not translated and remained in English. |
Makes sense, just made the Ctrl, Shift and Alt untranslated just like some of the other languages, please review the changes again. Thanks 🙏 |
Looks good to me. Thank you. |
71b9bb0 to
c57b33b
Compare
c57b33b to
0ae31ba
Compare
|
Hi! I've received several PRs for translations since yesterday. As you may have read, a small binary size is an important goal. Long-term this forces me to decide which languages to bundle with the editor. It also shouldn't be such a large number of localizations that maintenance becomes a burden. For instance, I only speak 2 languages, so any strings I add will be translated using LLMs most likely. But simultaneously, I don't want to reject languages that people are willing to maintain, or those that people are interested in. I think I need a few days to think about this and a bit time to toy around with #165. If you have any input to that issue, please let me know over there. I apologize for the delay but am very grateful that you took your time to do this. 🙂 |
I hope I got all the names right as I had to pull them out manually. The majority of PRs required changes to make them work. Closes #108 Closes #114 Closes #125 Closes #130 Closes #144 Closes #148 Closes #314 Closes #358 Closes #373 Closes #402 Closes #437 Closes #465 Closes #497 Closes #502 Closes #514 Closes #585 Co-authored-by: Ebrahim Byagowi <ebrahim@gnu.org> Co-authored-by: Mads Ohm Larsen <mads.ohm@gmail.com> Co-authored-by: william.beino <william.beino@gamifiera.com> Co-authored-by: marinac-dev <github@regex-sh.com> Co-authored-by: marginal23326 <58261815+marginal23326@users.noreply.github.com> Co-authored-by: NandeMD <celikumutcan2001@gmail.com> Co-authored-by: Mekan Soltanov <mknsltnw@gmail.com> Co-authored-by: Þór Sigurðsson <thor@ttk.is> Co-authored-by: Skryta Istota <48822204+hidden-being@users.noreply.github.com> Co-authored-by: Piotr Błażejewicz <peterblazejewicz@users.noreply.github.com> Co-authored-by: schilive <schilive100@gmail.com> Co-authored-by: Jakub Kolčář <j.kolcar@raynet.cz> Co-authored-by: Michael Avagianos <hello@maikkun.dev> Co-authored-by: Ruzsinszki Gábor <ruzsinszki.gabor@gmail.com> Co-authored-by: erithax <erithax@proton.me> Co-authored-by: spinualexandru <spinualexandru@outlook.com> Co-authored-by: Ronja Koistinen <ronja.koistinen@helsinki.fi> Co-authored-by: ykarpenko <ykarpenko@netfully.com>
I hope I got all the names right as I had to pull them out manually. The majority of PRs required changes to make them work. Closes #108 Closes #114 Closes #125 Closes #130 Closes #144 Closes #148 Closes #314 Closes #358 Closes #373 Closes #402 Closes #437 Closes #465 Closes #497 Closes #502 Closes #514 Closes #585 Co-authored-by: Ebrahim Byagowi <ebrahim@gnu.org> Co-authored-by: Mads Ohm Larsen <mads.ohm@gmail.com> Co-authored-by: william.beino <william.beino@gamifiera.com> Co-authored-by: marinac-dev <github@regex-sh.com> Co-authored-by: marginal23326 <58261815+marginal23326@users.noreply.github.com> Co-authored-by: NandeMD <celikumutcan2001@gmail.com> Co-authored-by: Mekan Soltanov <mknsltnw@gmail.com> Co-authored-by: Þór Sigurðsson <thor@ttk.is> Co-authored-by: Skryta Istota <48822204+hidden-being@users.noreply.github.com> Co-authored-by: Piotr Błażejewicz <peterblazejewicz@users.noreply.github.com> Co-authored-by: schilive <schilive100@gmail.com> Co-authored-by: Jakub Kolčář <j.kolcar@raynet.cz> Co-authored-by: Michael Avagianos <hello@maikkun.dev> Co-authored-by: Ruzsinszki Gábor <ruzsinszki.gabor@gmail.com> Co-authored-by: erithax <erithax@proton.me> Co-authored-by: spinualexandru <spinualexandru@outlook.com> Co-authored-by: Ronja Koistinen <ronja.koistinen@helsinki.fi> Co-authored-by: ykarpenko <ykarpenko@netfully.com>
I hope I got all the names right as I had to pull them out manually. The majority of PRs required changes to make them work. Closes microsoft#108 Closes microsoft#114 Closes microsoft#125 Closes microsoft#130 Closes microsoft#144 Closes microsoft#148 Closes microsoft#314 Closes microsoft#358 Closes microsoft#373 Closes microsoft#402 Closes microsoft#437 Closes microsoft#465 Closes microsoft#497 Closes microsoft#502 Closes microsoft#514 Closes microsoft#585 Co-authored-by: Ebrahim Byagowi <ebrahim@gnu.org> Co-authored-by: Mads Ohm Larsen <mads.ohm@gmail.com> Co-authored-by: william.beino <william.beino@gamifiera.com> Co-authored-by: marinac-dev <github@regex-sh.com> Co-authored-by: marginal23326 <58261815+marginal23326@users.noreply.github.com> Co-authored-by: NandeMD <celikumutcan2001@gmail.com> Co-authored-by: Mekan Soltanov <mknsltnw@gmail.com> Co-authored-by: Þór Sigurðsson <thor@ttk.is> Co-authored-by: Skryta Istota <48822204+hidden-being@users.noreply.github.com> Co-authored-by: Piotr Błażejewicz <peterblazejewicz@users.noreply.github.com> Co-authored-by: schilive <schilive100@gmail.com> Co-authored-by: Jakub Kolčář <j.kolcar@raynet.cz> Co-authored-by: Michael Avagianos <hello@maikkun.dev> Co-authored-by: Ruzsinszki Gábor <ruzsinszki.gabor@gmail.com> Co-authored-by: erithax <erithax@proton.me> Co-authored-by: spinualexandru <spinualexandru@outlook.com> Co-authored-by: Ronja Koistinen <ronja.koistinen@helsinki.fi> Co-authored-by: ykarpenko <ykarpenko@netfully.com>
It works in a terminal with support of bidi (the screenshot below is from Terminal.app when #72 is applied)
LANG=fa cargo runI'm aware of #37, this isn't related to editing of RTL documents but just localization for a language with RTL script.
About the translation itself, translation of "Alt", "Ctrl" and "Shift" come from https://persian-computing.org/archives/ISIRI/ISIRI-9147.pdf page 19(kept untranslated as below)This translation tries to follow:
If you want to review the translation itself please check these sources for making sure we are on the same page.