This repository was archived by the owner on Jan 15, 2025. It is now read-only.
fix activeVersion is null issue when updating application failed#827
Merged
munozemilio merged 1 commit intomasterfrom May 27, 2020
Merged
fix activeVersion is null issue when updating application failed#827munozemilio merged 1 commit intomasterfrom
munozemilio merged 1 commit intomasterfrom
Conversation
vishwacsena
approved these changes
May 27, 2020
munozemilio
approved these changes
May 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #787. The activeVersion will be null if users are trying to update an application with errors returned from luis api. After the fix, versionId will come from appInfo.endpoints.PRODUCTION.versionId if appInfo.activeVersion is null due to updating failure. Tests are added to cover the scenario. Manual E2E tests also work well for the cases reported in issue #787.