Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/lu/src/parser/lubuild/builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ export class Builder {
async updateApplication(currentApp: any, luBuildCore: LuBuildCore, recognizer: Recognizer, delayDuration: number, deleteOldVersion: boolean) {
await delay(delayDuration)
const appInfo = await luBuildCore.getApplicationInfo(recognizer.getAppId())
recognizer.versionId = appInfo.activeVersion
recognizer.versionId = appInfo.activeVersion || appInfo.endpoints.PRODUCTION.versionId

await delay(delayDuration)
const existingApp = await luBuildCore.exportApplication(recognizer.getAppId(), recognizer.versionId)
Expand Down
70 changes: 70 additions & 0 deletions packages/luis/test/commands/luis/build.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -792,4 +792,74 @@ describe('luis:build create a new application successfully with locale set to it
expect(ctx.stdout).to.contain('publishing finished')
expect(ctx.stdout.includes('personName is not available for the requested locale: it-it')).to.be.false
})
})

describe('luis:build update application succeed when activeVersion is null', () => {
const existingLuisApp = require('./../../fixtures/testcases/lubuild/sandwich/luis/test(development)-sandwich.utteranceAdded.en-us.lu.json')
before(function () {
nock('https://westus.api.cognitive.microsoft.com')
.get(uri => uri.includes('apps'))
.reply(200, [{
name: 'test(development)-sandwich.en-us.lu',
id: 'f8c64e2a-8635-3a09-8f78-39d7adc76ec5'
}])

nock('https://westus.api.cognitive.microsoft.com')
.get(uri => uri.includes('apps'))
.reply(200, {
name: 'test(development)-sandwich.en-us.lu',
id: 'f8c64e2a-8635-3a09-8f78-39d7adc76ec5',
activeVersion: null,
endpoints: {
PRODUCTION: {
versionId: '0.1'
}
}
})

nock('https://westus.api.cognitive.microsoft.com')
.get(uri => uri.includes('export'))
.reply(200, existingLuisApp)

nock('https://westus.api.cognitive.microsoft.com')
.post(uri => uri.includes('import'))
.reply(201, '0.2')

nock('https://westus.api.cognitive.microsoft.com')
.post(uri => uri.includes('train'))
.reply(202, {
statusId: 2,
status: 'UpToDate'
})

nock('https://westus.api.cognitive.microsoft.com')
.get(uri => uri.includes('train'))
.reply(200, [{
modelId: '99999',
details: {
statusId: 0,
status: 'Success',
exampleCount: 0
}
}])

nock('https://westus.api.cognitive.microsoft.com')
.post(uri => uri.includes('publish'))
.reply(201, {
versionId: '0.2',
isStaging: true
})
})

test
.stdout()
.command(['luis:build', '--in', './test/fixtures/testcases/lubuild/sandwich/lufiles/sandwich.en-us.lu', '--authoringKey', uuidv1(), '--botName', 'test', '--log', '--suffix', 'development'])
.it('should update a luis application when activeVersion is null', ctx => {
expect(ctx.stdout).to.contain('Handling applications...')
expect(ctx.stdout).to.contain('creating version=0.2')
expect(ctx.stdout).to.contain('training version=0.2')
expect(ctx.stdout).to.contain('waiting for training for version=0.2')
expect(ctx.stdout).to.contain('publishing version=0.2')
expect(ctx.stdout).to.contain('publishing finished')
})
})