Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append Composer ui schema 'flow' part to component schema files #3239

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

yeze322
Copy link
Contributor

@yeze322 yeze322 commented Jan 29, 2021

(Copied from C#. Refs microsoft/botbuilder-dotnet#5099)
follows #2986

Description

In #2986, we port the ui schema form part to runtime in order to support the customization of Composer Form Editor;
in this PR, the flow part is added to runtime as well to support the customization of Composer Flow Editor.

Refs ui.schema definition change in SDK repo: microsoft/botframework-sdk#6163

Affected SDK $kinds

  • QnAMakerDialog
  • BeginDialog
  • BeginSkill
  • CancelAllDialog
  • DeleteProperty, DeleteProperties
  • EditActions
  • EditArray
  • EmitEvent
  • Foreach, ForeachPage
  • GetActivityMembers, GetConversationMembers
  • HttpRequest
  • IfCondition
  • ReplaceDialog
  • SendActivity
  • SetProperties, SetProperty
  • SwitchCondition
  • ThrowException
  • UpdateActivity
  • Ask
  • AttachmentInput, ChoiceInput, ConfirmInput, DateTimeInput, NumberInput, TextInput
  • OAuthInput

Example

Below is an example of the flow schema:

{
    "$schema": "https://schemas.botframework.com/schemas/ui/v1.0/ui.schema",
    "form": {...},
    "flow": {
        "widget": "ActionCard",
        "body": {
            "widget": "ResourceOperation",
            "operation": "=coalesce(action.changeType, \"?\")",
            "resource": "=coalesce(action.itemsProperty, \"?\")"
        },
        "footer": {
            "widget": "PropertyDescription",
            "property": "=action.resultProperty",
            "description": "= Result"
        },
        "hideFooter": "=!action.resultProperty"
    }
}

which describes the Microsoft.EditArray type in Composer as
image

@yeze322 yeze322 requested review from chrimc62, tomlm and a team as code owners January 29, 2021 04:28
@yeze322 yeze322 changed the title uischema: port composer ui schema 'flow' part to component schema files Append Composer ui schema 'flow' part to component schema files Jan 29, 2021
@coveralls
Copy link

coveralls commented Jan 29, 2021

Pull Request Test Coverage Report for Build 519949063

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 84.702%

Totals Coverage Status
Change from base Build 519010468: -0.01%
Covered Lines: 18071
Relevant Lines: 20366

💛 - Coveralls

@joshgummersall joshgummersall merged commit 58b9f12 into microsoft:main Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants