Add schemas from C# to packages. #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrimc62
requested review from
joshgummersall,
stevengum,
tomlm and
a team
as code owners
stevengum
approved these changes
Oct 31, 2020
chrimc62
added a commit
that referenced
this pull request
Oct 31, 2020
stevengum
pushed a commit
that referenced
this pull request
Oct 31, 2020
This was referenced Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schemas were missing from npm packages. This adds them from C#. The changes were to copy from C# to the corresponding places in node and add the files to package.json. This was tested by doing a merge and ensuring the merged files were a strict subset of tests.schema in the C# repo. Once this builds I will also run the daily to create packages and ensure they work and merge in a test project.