Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uischema: port composer ui schema 'flow' part to component schema files #5099

Merged
merged 3 commits into from
Jan 28, 2021

Conversation

yeze322
Copy link
Contributor

@yeze322 yeze322 commented Jan 15, 2021

follows #4341

Description

In #4341, we port the ui schema form part to runtime in order to support the customization of Composer Form Editor;
in this PR, the flow part is added to runtime as well to support the customization of Composer Flow Editor.

Refs ui.schema definition change in SDK repo: microsoft/botframework-sdk#6163

Affected SDK $kinds

  • QnAMakerDialog
  • BeginDialog
  • BeginSkill
  • CancelAllDialog
  • DeleteProperty, DeleteProperties
  • EditActions
  • EditArray
  • EmitEvent
  • Foreach, ForeachPage
  • GetActivityMembers, GetConversationMembers
  • HttpRequest
  • IfCondition
  • ReplaceDialog
  • SendActivity
  • SetProperties, SetProperty
  • SwitchCondition
  • ThrowException
  • UpdateActivity
  • Ask
  • AttachmentInput, ChoiceInput, ConfirmInput, DateTimeInput, NumberInput, TextInput
  • OAuthInput

Example

Below is an example of the flow schema:

{
    "$schema": "https://schemas.botframework.com/schemas/ui/v1.0/ui.schema",
    "form": {...},
    "flow": {
        "widget": "ActionCard",
        "body": {
            "widget": "ResourceOperation",
            "operation": "=coalesce(action.changeType, \"?\")",
            "resource": "=coalesce(action.itemsProperty, \"?\")"
        },
        "footer": {
            "widget": "PropertyDescription",
            "property": "=action.resultProperty",
            "description": "= Result"
        },
        "hideFooter": "=!action.resultProperty"
    }
}

which describes the Microsoft.EditArray type in Composer as
image

Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI schema needs to be updated to reflect all of these properties.

@chrimc62
Copy link
Contributor

And also the .schema. In particular you need to run tests and check the all-up test.schema/.uischema to make sure they have the changes you expect.


In reply to: 571498269 [](ancestors = 571498269)

@yeze322
Copy link
Contributor Author

yeze322 commented Jan 21, 2021

Updated the schema merge result.
Notes that test.schema is also affected because of the change of LogAction in #5036

Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants