uischema: port uischema 'trigger' part to component schema files #5160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
force-pushed
the
uischema/trigger
branch
from
99c9a97
to
9a09236
Compare
3 tasks
This comment has been minimized.
This comment has been minimized.
EricDahlvang
approved these changes
Feb 10, 2021
|
We can merge this PR after microsoft/botframework-sdk#6178 checked in. @EricDahlvang thanks for the approval! The PR in Composer for enabling new Teams Trigger doesn't need to be a dependency of this one. I will create another PR for Teams scenario specifically. |
a-b-r-o-w-n
approved these changes
Feb 16, 2021
EricDahlvang
pushed a commit
that referenced
this pull request
Feb 17, 2021
* add trigger uischema * update whitespaces
mrivera-ms
pushed a commit
that referenced
this pull request
Feb 19, 2021
* Update handoff action uischema to show in Composer action menu (#5231) * uischema: port uischema 'trigger' part to component schema files (#5160) * add trigger uischema * update whitespaces * update UT output uischema * add Teams Actions menu uischema * add trigger uischema for Teams Triggers * check in merged uischema Co-authored-by: Gary Pretty <gary@garypretty.co.uk>
EricDahlvang
pushed a commit
that referenced
this pull request
Apr 7, 2021
* Update handoff action uischema to show in Composer action menu (#5231) * uischema: port uischema 'trigger' part to component schema files (#5160) * add trigger uischema * update whitespaces * update UT output uischema * add Teams Actions menu uischema * add trigger uischema for Teams Triggers * check in merged uischema Co-authored-by: Gary Pretty <gary@garypretty.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #4341
Follows #5099
Description
In #4341, we port the ui schema
formpart to runtime in order to support the customization of Composer Form Editor;In #5099, we port the ui schema
flowpart to support the customization of Action UI;in this PR, the
triggerpart is added to runtime as well to support the customization of Composer's Trigger creation wizard.Refs ui.schema definition change in SDK repo: microsoft/botframework-sdk#6178
Affected SDK $kinds
Example of 'trigger' uischema
Take
Microsoft.OnMessageActivityas an example:Composer will take this uischema and let
OnMessageActivityappear under 'Activities'