Skip to content
This repository was archived by the owner on May 28, 2025. It is now read-only.

Conversation

@rajsesh
Copy link
Contributor

@rajsesh rajsesh commented Mar 1, 2017

This change is Reviewable

oliversa-msft and others added 8 commits February 28, 2017 16:41
This adds a few more failure cases for bad bitmap contexts,
and changes format imputation in the CG<->WIC mapper.
* GLKTexture load files without assuming it's PNG

* update others

*  intro of a new function

* update name
…#2117)

* `-[CALayer renderInContext:]` has the ability to render a cached version of itself; it was doing so upside-down because it was using a Cairo implementation detail.
* `-[UIImage drawAtPoint:]` squashed every image it rendered because it switched width & height.

The bug in UIImage dates back to the Cairo implementation as well; the invalid size was passed to a function that ignored it. When our refactor made use of that parameter, things rapidly went south.
We did not catch the second regression because all the images we drew with it were square.

Fixes microsoft#2095.
Copy link

@msft-Jeyaram msft-Jeyaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@rajsesh rajsesh merged commit 524a461 into microsoft:master Mar 1, 2017
@rajsesh rajsesh deleted the release_1702.2 branch March 1, 2017 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants