This repository was archived by the owner on May 28, 2025. It is now read-only.
Update Xib2Nib logic removing UIRoundedRectButton as a separate class #2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredhms
reviewed
Feb 22, 2017
| if (type) { | ||
| if (strcmp(type, "roundedRect") == 0) { | ||
| getAttrAndHandle("buttonType"); | ||
| // TODO: Investigate why this value deviates from UIButtonType |
Contributor
There was a problem hiding this comment.
// TODO: Investigate why this value deviates from UIButtonType [](start = 11, length = 64)
is it trying to map to system? seems like an odd place to do it... #Closed
Contributor
There was a problem hiding this comment.
i really hate all of the magic constants in this codebase :'(
In reply to: 102358850 [](ancestors = 102358850)
Contributor
Author
There was a problem hiding this comment.
We'd have to crack open the NIB from iOS and inspect its values for various UIButton types to see if they align with UIButtonType*. Right now, I don't know if this value is correct - might be a legacy value or just a hack.
In reply to: 102358917 [](ancestors = 102358917,102358850)
Contributor
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the subclassed UIRoundedRectButton from UIButton.mm in commit (87dd17b). As a result, we need to remove the logic from Xib2Nib that relied on this class implementation
Fixes #1975