Fixed a regression with string completions not being available directly in arguments typed using rest parameter #54588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly in arguments typed using rest parameter
typescript-bot
added
the
For Uncommitted Bug
Andarist
commented
Jun 9, 2023
| @@ -388,7 +388,7 @@ function getStringLiteralCompletionEntries(sourceFile: SourceFile, node: StringL | |||
| // Get string literal completions from specialized signatures of the target | |||
| // i.e. declare function f(a: 'A'); | |||
| // f("/*completion position*/") | |||
| return argumentInfo && getStringLiteralCompletionsFromSignature(argumentInfo.invocation, node, argumentInfo, typeChecker) || fromContextualType(); | |||
| return argumentInfo && getStringLiteralCompletionsFromSignature(argumentInfo.invocation, node, argumentInfo, typeChecker) || fromContextualType(ContextFlags.None); | |||
There was a problem hiding this comment.
getStringLiteralCompletionsFromSignature is already using the "inference blocking strategy" so it doesn't make sense (at least usually) for the fallback request~ to use it as well
|
@andrewbranch i wonder if there is a chance to cherry-pick this into 5.1 |
|
^ @DanielRosenwasser what do you think |
|
@typescript-bot cherry-pick this to release-5.1 |
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
|
Hey @DanielRosenwasser, I've opened #54635 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Jun 13, 2023
Component commits: 8e1f8b6 Fixed a regression with string completions not being available directly in arguments typed using rest parameter
This was referenced Jun 20, 2023
DanielRosenwasser
pushed a commit
that referenced
this pull request
Jun 26, 2023
…e-5.1 (#54635) Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #54572 (a regression from #52717 )
cc @andrewbranch