Skip to content

Regression in autocompletion on spread generic argumentsΒ #54572

Closed

Description

Bug Report

πŸ”Ž Search Terms

autocomplete, regression

πŸ•— Version & Regression Information

  • This changed between versions 5.0.4 and 5.1.3

⏯ Playground Link

Playground link with relevant code

πŸ’» Code

function fn<T extends ('value1' | 'value2' | 'value3')[]>(...values: T): T { return values; }

const value1 = fn('');
const value2 = fn('value1', '');

πŸ™ Actual behavior

It should autocomplete inside both '' (empty string) places with value1|value2|value3 possible values, however it shows incorrect (kind of randomly gathered) options. For eg.:

image

πŸ™‚ Expected behavior

It should show only value1 / value2 / value3 options (as it does correctly with 5.0.4 and before), like this:

image

This issue could be related to (#53555) and (#52726) but I think my case is more basic, and appeared only in the latest (5.1.3) version of TS. (couldn't test if versions between 5.1.0 and 5.1.3 were affected or not, I could test only 5.1.3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Domain: Completion ListsThe issue relates to showing completion lists in an editorHelp WantedYou can do thisPossible ImprovementThe current behavior isn't wrong, but it's possible to see that it might be better in some cases

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions