Cherry-pick PR microsoft#54588 into release-5.1

Component commits: 8e1f8b6 Fixed a regression with string completions not being available directly in arguments typed using rest parameter
typescript-bot · Jun 13, 2023 · 1e896e5 · 1e896e5
1 parent e6ceba0
commit 1e896e5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/services/stringCompletions.ts b/src/services/stringCompletions.ts
@@ -387,7 +387,7 @@ function getStringLiteralCompletionEntries(sourceFile: SourceFile, node: StringL
                 // Get string literal completions from specialized signatures of the target
                 // i.e. declare function f(a: 'A');
                 // f("/*completion position*/")
-                return argumentInfo && getStringLiteralCompletionsFromSignature(argumentInfo.invocation, node, argumentInfo, typeChecker) || fromContextualType();
+                return argumentInfo && getStringLiteralCompletionsFromSignature(argumentInfo.invocation, node, argumentInfo, typeChecker) || fromContextualType(ContextFlags.None);
             }
             // falls through (is `require("")` or `require(""` or `import("")`)
 

diff --git a/tests/cases/fourslash/completionsLiteralDirectlyInRestConstrainedToArrayType.ts b/tests/cases/fourslash/completionsLiteralDirectlyInRestConstrainedToArrayType.ts
@@ -0,0 +1,9 @@
+/// <reference path="fourslash.ts" />
+// @strict: true
+////
+//// function fn<T extends ('value1' | 'value2' | 'value3')[]>(...values: T): T { return values; }
+//// 
+//// const value1 = fn('/*1*/');
+//// const value2 = fn('value1', '/*2*/');
+
+verify.completions({ marker: ["1", "2"], includes: [`value1`, `value2`, `value3`] })