Fix child element indentation in multiline lists

[saschanaz]

Fixes #3817, fixes #5834, fixes #9437.

Please don't do commit-by-commit review as some intermediate changes were later removed.

Note (July 1, 2016): This sadly reverts #8364.

Input:

return (
    h.div({
    },
        ""
    )
);

[3, {
}, {
    }]

Fix:

return (
    h.div({
    },
    ""
    )
);

[3, {
}, {
}]

[saschanaz]

Now waiting feedback.

[wgebczyk]

So after the fix we have:

return (
    h.div({
        className: "view-node-row",
        style: {
            width: width,
            height: rowHeight
        }
    },
    backgroundElement,
    centerElement,
    toolsElement,
    h.div({ className: "nodes" }, items)
    )
);

this means probably we will have this:

return (
    h.div(backgroundElement,
    centerElement,
    toolsElement,
    h.div({ className: "nodes" }, items)
    )
);

and seems that by unwrapping return we will have this:

h.div(backgroundElement,
centerElement,
toolsElement,
h.div({ className: "nodes" }, items)
);

Is that correct?

Honestly I don't like situation when function parameters are indented at same level as its function call.
But that's my preference...

[saschanaz]

@wgebczyk No, this fix will affect only when:

1. The end position of a parameter is in a different line with the start position of the list
2. The start position of the parameter is in the same line with the start position of the list

foo({ // An object literal starts in the first line
}, // An object literal ends in the second line, not the first line
3 // Thus, no additional indentation here
),

foo(
    { // starts in the second line
    },  
    3 // Additional indentation here
);

foo({}, // starts and ends in the first line
    3 // Additional indentation here
);

[wgebczyk]

Seems to be reasonable. Thanks!

[mhegazy]

@vladima can you take a look?

[zpdDG4gta8XKpMCd]

can we merge it please?

[saschanaz]

I'm closing this because this is incompatible with new PR #13574. I will open a cleaner PR if it is merged.