Fix indentation for array items#8364
Merged
zhengbli merged 1 commit intomicrosoft:masterfrom May 17, 2016
Merged
Conversation
|
|
||
| childContextNode = node; | ||
|
|
||
| if (isFirstListItem && parent.kind === SyntaxKind.ArrayLiteralExpression && inheritedIndentation === Constants.Unknown) { |
Contributor
There was a problem hiding this comment.
why do we need to specialize it to array, should not the firstListItem be enough indicator?
Contributor
Author
There was a problem hiding this comment.
It would break cases for other things like parameter list
function test(p1: string,
p2: number) {}
Contributor
There was a problem hiding this comment.
Is there a test that guards parameter list formatting?
Contributor
|
@vladima any concerns? |
Contributor
|
👍 |
| ////}/*6*/, | ||
| //// { | ||
| //// Salad: 'salad', /*7*/ | ||
| //// Burrito: 'burrito', |
Contributor
There was a problem hiding this comment.
What happens to one-line arrays, would format.document() break those?
var some = [
{
cheeses: ["stilton", "brie", "cheddar"] // <-- here, does this survive one-lined?
}
];
Contributor
There was a problem hiding this comment.
no. we did that at some point in the past and ppl hated it :)
mhegazy
added a commit
that referenced
this pull request
May 17, 2016
Extra test for #8364 - non-breaking of one-liners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7503