Visual Studio formatting is wrong in some cases

[ahmelsayed]

Here is an example

var webApps: ng.ui.IState[] = [{
    name: "home.webapp",
    templateUrl: "templates/empty-shell.html"
}, {
    name: "home.webapp.templates",
    templateUrl: "templates/templates.html"
}, {
    name: "home.webapp.work",
    templateUrl: "templates/work.html"
}];

VS formats it to

var webApps: ng.ui.IState[] = [{
    name: "home.webapp",
    templateUrl: "templates/empty-shell.html"
}, {
        name: "home.webapp.templates",
        templateUrl: "templates/templates.html"
    }, {
        name: "home.webapp.work",
        templateUrl: "templates/work.html"
    }];

another example is

function test($http: ng.IHttpService) {
    $http({
        url: "https://github.com",
        method: "GET"
    })
    .success((d) => {
        console.log(d);
    })
    .finally(() => {
        console.log("finally");
    });
}

VS formats it to

function test($http: ng.IHttpService) {
    $http({
        url: "https://github.com",
        method: "GET"
    })
        .success((d) => {
            console.log(d);
        })
        .finally(() => {
            console.log("finally");
        });
}

[wgebczyk]

I agree on array thing.

The method chain call is another story. Hard to say if its the bug, as probably it would depend on personal preferences.

Take this example of 2 functions:

function test1() {
return
"a".
toLower().
toUpper().
toCrap();
}
function test2() {
return $http({}).
success({}).
finally({});
}

The first function might be as those two variants (at least!)

function test1() {
  return "a"
  .toLower()
  .toUpper()
  .toCrap();
}
OR
function test1() {
  return "a"
    .toLower()
    .toUpper()
    .toCrap();
}

I would like to see it even as:

function test1() {
  return "a"
    .toLower()
    .toUpper()
    .toCrap()
  ;
}

... where "return" and ";" defines range statement.

Now apply this to test2 and see what are the results.

[saschanaz]

#3827 will cover the first example. Not sure what should be done on the second one, JSBeautifier even does this:

function test($http: ng.IHttpService) {
    $http({
            url: "https://github.com",
            method: "GET"
        })
        .success((d) => {
            console.log(d);
        })
        .finally(() => {
            console.log("finally");
        });
}

PS: #3827 now correctly formats the first example.

[NickAb]

I also have run into strange formatting behaviour. Seems that it indents parameters one level only, independently of the actual nesting level of functions. This makes it harder to glance over and see what parameters belong where in promises.

Actual:

        public import() {
            if (this.isImporting) {
                return;
            }
            this.isImporting = true;
            this.floorPlansRepository.import()
                .then(
                success => { // <- note `success` being indented on the same level as `.then`
                    this.fetch();
                },
                error => {
                    this.notificationService.showErrorResponse(error);
                })
                .finally(() => {
                    this.isImporting = false;
                });
        }

Expected:

        public import() {
            if (this.isImporting) {
                return;
            }
            this.isImporting = true;
            this.floorPlansRepository.import()
                .then(
                    success => {  // <- note `success` being indented one level deeper then `.then`
                        this.fetch();
                    },
                    error => {
                        this.notificationService.showErrorResponse(error);
                    })
                .finally(() => {
                    this.isImporting = false;
                });
        }

Also, ReSharper code reformat does the indentation, is it is really frustrating to see code format changing every time when editing it, as VS keeps reformatting it back.

[zpdDG4gta8XKpMCd]

@mhegazy i don't understand help wanted tags that you put, there were a few pull requests about fixing formatting and all got nowhere without any comments: https://github.com/Microsoft/TypeScript/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+format