Remove local forwarder channel #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Dec 9, 2019
...crosoft/applicationinsights/autoconfigure/ApplicationInsightsTelemetryAutoConfiguration.java
Outdated
Show resolved
Hide resolved
This reverts commit 82c9816.
littleaj
force-pushed
the
littleaj/remove_lf_channel
branch
from
afe3292 to
489404e
Compare
trask
approved these changes
Dec 10, 2019
Contributor
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
|
This pull request fixes 1 alert when merging c8fec7f into 09823c3 - view on LGTM.com fixed alerts:
|
trask
reviewed
Dec 12, 2019
|
|
||
| # Version 2.6.0-BETA.2 | ||
| * Removed Local Forwarder Channel. Local Forwarder is now a deprecated solution. | ||
| The classes and configuration elements which supported this solution have been removed. |
trask
pushed a commit
that referenced
this pull request
Oct 17, 2020
#1172) * Support injecting resources into classloader and use it in aws-sdk-2.2 instrumentation. * Use URL for duplication check instead of reading content and inject URLs directly instead of reading to byte array first. * Remove getResource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a series of modified reverts of commits related to local forwarder functionality.
I kept the extraction of TelemetryChannelBase and paramiterization of TelemetryBuffer, etc. because that seems to be working fine and could be quite difficult to push down any changes that may have been added into the extracted superclass.