Add lf channel in starter #739
Conversation
…rter and sdk, updating changelog
littleaj
left a comment
littleaj
left a comment
There was a problem hiding this comment.
Seems straightforward. Just remove the grpc qualification
...main/java/com/microsoft/applicationinsights/autoconfigure/ApplicationInsightsProperties.java
Outdated
Show resolved
Hide resolved
...crosoft/applicationinsights/autoconfigure/ApplicationInsightsTelemetryAutoConfiguration.java
Outdated
Show resolved
Hide resolved
…nnel autoconfig, update readme and changelog
|
@grlima could you please review this so it can be merged |
…ing autoconfig before springboot package
| exclude(dependency([group: 'com.google.guava', name: 'guava', version: '20.0'])) | ||
| exclude(dependency([group: 'com.google.code.gson', name: 'gson', version: '2.8.2'])) | ||
|
|
||
| // exclude gRPC and protobuf dependencies |
There was a problem hiding this comment.
I don't honestly like to have this long list of excluded dependencies. It would have been amazing if shadow jar could excluded transitive dependencies automatically :/
| }) | ||
| @AutoConfigureBefore(name = { | ||
| "io.micrometer.spring.autoconfigure.export.azuremonitor.AzureMonitorMetricsExportAutoConfiguration", | ||
| "org.springframework.boot.actuate.autoconfigure.metrics.export.azuremonitor.AzureMonitorMetricsExportAutoConfiguration" |
There was a problem hiding this comment.
I have removed this namespace because, the autoconfig code will reside in azure-spring-boot repo. I will add new namespace once the code is ported there and merged (possibly for next release)
|
@grlima can you please take a look and approve this one? |
|
@grlima I am merging this PR, it's pretty straight forward. We can change things with a new PR in case later you have any more questions. |
PR adds Auto Configuration for Local Forwarder Telemetry Channel. The Local Forwarder channel would be configured if following property is present -
azure.application-insights.channel.local-forwarder.endpoint-addressIf both
azure.application-insights.channel.local-forwarder.endpoint-addressas well asazure.application-insights.channel.in-process.endpoint-addressare present in the properties this would be considered as Illegal Configuration and the application would throw in this case.For significant contributions please make sure you have completed the following items: