added proto files and protobuf/grpc build plugin #715
Conversation
dhaval24
left a comment
dhaval24
left a comment
There was a problem hiding this comment.
In general this looks good to me. I believe most of proto files are autogenerated via the plugin which is definitely awesome! I just gave a heads up on one of the comments. If that is fine, I am fine with this changes going through! Ensure, that all smoke tests pass and I would also like to try on SpringBoot app too to see if all is good there.
| int32 ver = 1; | ||
|
|
||
| // only one metric in the list is currently supported by Application Insights storage. If multiple data points were sent only the first one will be used. | ||
| repeated DataPoint metrics = 2; |
There was a problem hiding this comment.
I still believe that this List should be depreciated from the MetricData class which is creating this non-sense. Indeed we can bring in all the fields in the MetricData class inside the DataPoint class and just deprecate the whole class itself. It is of no use IMO and is just taking Memory footprint. Anyways, can be a conversation for seperate PR.
Not much else to say here. The files aren't used yet so this won't have an impact on the current functionality.
Do review the changes to the shadowing configuration with more rigor. I changed the paths to some of our dependencies. This shouldn't affect anything unless someone is using the dependency out of our package (which shouldn't be happening).