-
Notifications
You must be signed in to change notification settings - Fork 140
Readme examples minor #2028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme examples minor #2028
Conversation
# Conflicts: # core/src/main/java/com/predic8/membrane/core/interceptor/apikey/stores/JDBCApiKeyStore.java
WalkthroughThis update revises documentation files by restructuring and expanding example overviews, updating and correcting links, paths, and formatting in the main README, and reorganizing changelog entries in the roadmap. No changes were made to code or configuration; all updates are limited to documentation content and structure. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
README.md (1)
1101-1134
: Duplicate “Monitoring with Prometheus and Grafana” section creates noise.The same H3 heading and almost identical instructions appear twice (Lines 1101-1114 and 1122-1134). Merge them into a single section to avoid reader confusion and maintenance overhead.
🧹 Nitpick comments (5)
docs/ROADMAP.md (1)
35-55
: Consider removing internal placeholders such as “(TB)” before publishing.Several bullet points still contain the marker “(TB)” (to-be-done). Leaving these in a public roadmap can be confusing for readers and gives the impression that the list is still draft-quality.
If these items really are open tasks, move them to an issue tracker instead and keep the roadmap concise.README.md (3)
80-83
: Missing list marker breaks Markdown list rendering.Line 80 starts with bold text but lacks the leading “- ” used by the surrounding list items.
-**Admin Web Console** for monitoring and management. +- **Admin Web Console** for monitoring and management.
323-326
: Typo: “Custum” → “Custom”.-| `test` | - Custum script … +| `test` | - Custom script …
1133-1134
: Minor wording – “have a look” → “take a look”.LanguageTool flagged this; the American English idiom is “take a look”.
-… have a look at [examples/prometheus]… +… take a look at [examples/prometheus]…distribution/examples/README.md (1)
74-77
: Heading formatting: “### XML(xml)” looks accidental.The parenthesis duplicates the word and renders oddly.
-### XML(xml) +### XML
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/images/api-gateway-ebook-cover.jpg
is excluded by!**/*.jpg
📒 Files selected for processing (3)
README.md
(10 hunks)distribution/examples/README.md
(1 hunks)docs/ROADMAP.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
70-70: Link fragments should be valid
Expected: #api-keys; Actual: #API-Keys
(MD051, link-fragments)
🪛 LanguageTool
README.md
[locale-violation] ~1133-~1133: In American English, “take a look” is more commonly used.
Context: ...ete example with prometheus and Grafana have a look at [examples/prometheus](distribution/e...
(HAVE_A_LOOK)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (java)
🔇 Additional comments (1)
README.md (1)
54-60
: Verify e-book image/URL paths.The image uses an absolute path
/docs/images/api-gateway-ebook-cover.jpg
and the PDF is linked directly from an external site.
• Make sure the image exists at that location inside the repository (GitHub will treat the leading “/” as repository-root).
• Consider pinning the PDF to a version tag or static location to avoid future 404s.
Summary by CodeRabbit