-
Notifications
You must be signed in to change notification settings - Fork 140
animated gif membrane demo #2146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdded an animated demo GIF banner to README.md and applied multiple editorial fixes across the README (typos, grammar, wording, and formatting). No code, configuration, or public API changes were made. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
346-349
: Fix user-facing typos/grammar in docsSmall wording issues reduce polish; suggest the edits below.
- | `method` | - HTTP method (e.g., `GET`, `POST`, `DELETE`).<br>- `*` matchs any method. | - | `test` | - Custum script e.g. `$pathParm.id == '42'`, `$header.contentType == '...'` | + | `method` | - HTTP method (e.g., `GET`, `POST`, `DELETE`).<br>- `*` matches any method. | + | `test` | - Custom script e.g. `$pathParam.id == '42'`, `$header.contentType == '...'` |- <static>I'am fine.</static> + <static>I'm fine.</static>- println "I'am executed in the ${flow} flow" + println "I'm executed in the ${flow} flow"- I'am executed in the REQUEST flow + I'm executed in the REQUEST flow @@ - I'am executed in the RESPONSE flow + I'm executed in the RESPONSE flow-Then the properties are available as variables inside `template`. -plugin. +Then the properties are available as variables inside the `template` plugin.-- **Object Size**: Maximum number of fields in aJSON object. +- **Object Size**: Maximum number of fields in a JSON object.Also applies to: 364-365, 437-454, 697-698, 1017-1018
🧹 Nitpick comments (1)
README.md (1)
8-10
: Optimize README demo media for performance & accessibilityVerified docs/images/api-gateway-demo.gif exists (407,176 bytes ≈ 0.39 MB), is a real GIF (GIF89a), and .gitattributes contains no Git LFS entries.
File: README.md (lines 8–10)
- Add descriptive alt text and constrain display width to avoid layout shifts.
- Provide MP4/WebM alongside the GIF if you want smaller/faster playback (GIF size is small here, so optional).
- +<img src="docs/images/api-gateway-demo.gif" + alt="Animated demo of Membrane API Gateway (routing, admin console, request flow)" + width="800" />Or:
- +<details> + <summary>API Gateway demo (click to view)</summary> + <img src="docs/images/api-gateway-demo.gif" + alt="Animated demo of Membrane API Gateway (routing, admin console, request flow)" + width="800" /> + <p>Prefer video? <a href="docs/videos/api-gateway-demo.mp4">Watch MP4</a></p> +</details>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/images/api-gateway-demo.gif
is excluded by!**/*.gif
📒 Files selected for processing (1)
README.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Automated tests
- GitHub Check: Analyze (java)
Summary by CodeRabbit