-
Notifications
You must be signed in to change notification settings - Fork 140
Readme examples minor #2029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme examples minor #2029
Conversation
# Conflicts: # core/src/main/java/com/predic8/membrane/core/interceptor/apikey/stores/JDBCApiKeyStore.java
WalkthroughThis update restructures and enhances documentation across several README files, introducing new overview and index documents for example directories, reorganizing content for clarity, and correcting or improving example references. The docs/ROADMAP.md file is also reorganized for better version tracking. No technical or code changes are included. Changes
Sequence Diagram(s)No sequence diagram generated, as the changes are limited to documentation structure and content. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
README.md (1)
1096-1122: Duplicate “Monitoring with Prometheus and Grafana” sectionThe identical heading appears twice (Lines 1098 and 1119). This dilutes navigation, and one copy already contains the full example link.
Delete the second occurrence (or merge new content into the first) to keep the TOC tidy.
🧹 Nitpick comments (5)
README.md (3)
80-83: Missing list marker breaks markdown rendering
**Admin Web Console** for monitoring and management.is missing the leading-used by the surrounding bullet items, so the line is rendered as a normal paragraph instead of being part of the list.-**Admin Web Console** for monitoring and management. +- **Admin Web Console** for monitoring and management.
70-70: Inconsistent anchor casing triggers MD051
#API-Keysis flagged because GitHub generates the anchor#api-keys(lower-case).
Updating the fragment avoids the markdown-lint warning and keeps anchors uniform.-[API Keys](#API-Keys) +[API Keys](#api-keys)Also applies to: 120-120
1130-1130: Minor phrasing – “take a look” is preferred-... have a look at [examples/prometheus] ... +... take a look at [examples/prometheus] ...distribution/examples/security/README.md (1)
19-20: Hyphenate compound adjective “Form-based”-* [Form based login](login) +* [Form-based login](login)distribution/examples/README.md (1)
74-76: Redundant heading text
### XML(xml)repeats the word in parentheses and looks like a typo. A plain heading is sufficient:-### XML(xml) +### XML
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/images/api-gateway-ebook-cover.jpgis excluded by!**/*.jpg
📒 Files selected for processing (5)
README.md(12 hunks)distribution/examples/README.md(1 hunks)distribution/examples/extending-membrane/README.md(1 hunks)distribution/examples/security/README.md(1 hunks)docs/ROADMAP.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
70-70: Link fragments should be valid
Expected: #api-keys; Actual: #API-Keys
(MD051, link-fragments)
🪛 LanguageTool
README.md
[locale-violation] ~1130-~1130: In American English, “take a look” is more commonly used.
Context: ...ete example with prometheus and Grafana have a look at [examples/prometheus](distribution/e...
(HAVE_A_LOOK)
🔇 Additional comments (2)
docs/ROADMAP.md (1)
48-51: Target directory looks inconsistentThe bullet says to “import in
examples/prometheus” but the follow-up line says to “place it inexamples/monitoring-tracing/graphql”.
Verify which folder is correct and adjust one of the paths to prevent future confusion.distribution/examples/extending-membrane/README.md (1)
21-24: Link slug appears to be miss-typed
file-exchangestoreis missing a hyphen compared to the actual example folderfile-exchange-store/.-* [File ExchangeStore](file-exchangestore) +* [File ExchangeStore](file-exchange-store)Do the same check for
mongo-exchange-storeif necessary.
Summary by CodeRabbit