Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Make Google Doc Canvas checks more lenient #962

Merged
merged 1 commit into from
Apr 7, 2022
Merged

fix(ui): Make Google Doc Canvas checks more lenient #962

merged 1 commit into from
Apr 7, 2022

Commits on Apr 7, 2022

  1. fix(ui): Make Google Doc Canvas checks more lenient 

    I found in offline mode I the cached Google Docs query selector was always false due to executing before page loaded. I now query the selector on every `mousemove` which seems fast enough. An improvement would be to memoize a function or perhaps add a on Dom loaded callback.
I also removed the check for if the target was `svg` or `rect` since there's at least one counter example to that assumption. For now let's avoid premature optimization.

I also had to update the tests to not overwrite the Google Docs class since it now needs to be present at each execution.

Fixes #897
Fixes #881
    @melink14
    melink14 committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    eee0d91 View commit details
    Browse the repository at this point in the history