Rikaikun doesn't work in Google Docs for some users (TrustedScript violation?) #881
Comments
|
Unfortunately, trusted types error was not the cause of the problem as confirmed by using ModHeader to force enforcement. My best guess now is some kind of bad interaction between extensions since by default Google Docs should have no such errors. |
|
Based on another thread on Twitter with this same error plus some other font 404s I'm starting to think that it might be a race condition when rikaikun runs too fast and sets |
melink14
added a commit
that referenced
this issue
Apr 7, 2022
I found in offline mode I the cached Google Docs query selector was always false due to executing before page loaded. I now query the selector on every `mousemove` which seems fast enough. An improvement would be to memoize a function or perhaps add a on Dom loaded callback. I also removed the check for if the target was `svg` or `rect` since there's at least one counter example to that assumption. For now let's avoid premature optimization. I also had to update the tests to not overwrite the Google Docs class since it now needs to be present at each execution. Fixes #897 Fixes #881
melink14
added a commit
that referenced
this issue
Apr 7, 2022
I found in offline mode I the cached Google Docs query selector was always false due to executing before page loaded. I now query the selector on every `mousemove` which seems fast enough. An improvement would be to memoize a function or perhaps add a on Dom loaded callback. I also removed the check for if the target was `svg` or `rect` since there's at least one counter example to that assumption. For now let's avoid premature optimization. I also had to update the tests to not overwrite the Google Docs class since it now needs to be present at each execution. Fixes #897 Fixes #881
|
🎉 This issue has been resolved in version 2.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From the support tab:
Maybe we can created a
TrustedScriptbut policy creation can also be hardened...Can check if google docs is running trusted types experiment...
refs:
https://web.dev/trusted-types/
The text was updated successfully, but these errors were encountered: