fix(ui): Make Google Doc Canvas checks more lenient #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found in offline mode I the cached Google Docs query selector was always false due to executing before page loaded. I now query the selector on every `mousemove` which seems fast enough. An improvement would be to memoize a function or perhaps add a on Dom loaded callback. I also removed the check for if the target was `svg` or `rect` since there's at least one counter example to that assumption. For now let's avoid premature optimization. I also had to update the tests to not overwrite the Google Docs class since it now needs to be present at each execution. Fixes #897 Fixes #881
Codecov Report
@@ Coverage Diff @@
## main #962 +/- ##
==========================================
- Coverage 79.01% 78.97% -0.05%
==========================================
Files 7 7
Lines 3007 3001 -6
Branches 175 174 -1
==========================================
- Hits 2376 2370 -6
Misses 628 628
Partials 3 3
Continue to review full report at Codecov.
|
|
Decrease in coverage is due to total number of lines decreasing. |
|
🎉 This PR is included in version 2.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found in offline mode I the cached Google Docs query selector was always false due to executing before page loaded. I now query the selector on every
mousemovewhich seems fast enough. An improvement would be to memoize a function or perhaps add a on Dom loaded callback.I also removed the check for if the target was
svgorrectsince there's at least one counter example to that assumption. For now let's avoid premature optimization.I also had to update the tests to not overwrite the Google Docs class since it now needs to be present at each execution.
Fixes #897
Fixes #881