-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Validium mode abstraction #1015
feat: Validium mode abstraction #1015
Commits on Jan 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f6c99ac - Browse repository at this point
Copy the full SHA f6c99acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9736d97 - Browse repository at this point
Copy the full SHA 9736d97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d9c427 - Browse repository at this point
Copy the full SHA 2d9c427View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24cd669 - Browse repository at this point
Copy the full SHA 24cd669View commit details -
Configuration menu - View commit details
-
Copy full SHA for af06969 - Browse repository at this point
Copy the full SHA af06969View commit details
Commits on Jan 26, 2024
-
- add basic abstraction for DataProvider for eth_tx_aggregator
- Needs to fix errors in tests related to the new Generic Data Type
Configuration menu - View commit details
-
Copy full SHA for 982d638 - Browse repository at this point
Copy the full SHA 982d638View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9548c8 - Browse repository at this point
Copy the full SHA d9548c8View commit details
Commits on Jan 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bf32093 - Browse repository at this point
Copy the full SHA bf32093View commit details
Commits on Jan 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 90e06d7 - Browse repository at this point
Copy the full SHA 90e06d7View commit details -
Remove l1_commit_data, l1_commit_data_size and construct_pubdata meth…
…ods from L1BatchWithMetadata as they're now part of the L1BatchCommitter trait and utils in the case of construct_pubdata
Configuration menu - View commit details
-
Copy full SHA for b6ba50c - Browse repository at this point
Copy the full SHA b6ba50cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f6d849 - Browse repository at this point
Copy the full SHA 7f6d849View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c714b9 - Browse repository at this point
Copy the full SHA 3c714b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 748fb83 - Browse repository at this point
Copy the full SHA 748fb83View commit details -
Add l1_batch_committer field to Aggregator struct for later L1BatchCo…
…mmitOperation construction and DatasizeCriterion::last_l1_batch_to_publish usage
Configuration menu - View commit details
-
Copy full SHA for 6467073 - Browse repository at this point
Copy the full SHA 6467073View commit details -
Add l1_batch_committer as a L1BatchPublishCriterion::last_l1_batch_to…
…_publish parameter (only used by DataSizeCriterion)
Configuration menu - View commit details
-
Copy full SHA for 5abeb45 - Browse repository at this point
Copy the full SHA 5abeb45View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8027bf - Browse repository at this point
Copy the full SHA d8027bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb3c7d1 - Browse repository at this point
Copy the full SHA bb3c7d1View commit details -
Update consistency_checker module where needed for using L1BatchCommi…
…tter::l1_commit_data function
Configuration menu - View commit details
-
Copy full SHA for 7f9ad63 - Browse repository at this point
Copy the full SHA 7f9ad63View commit details -
Update external_node module where needed for using L1BatchCommitter::…
…l1_commit_data function
Configuration menu - View commit details
-
Copy full SHA for fc2245f - Browse repository at this point
Copy the full SHA fc2245fView commit details -
Initialize the Aggregator with a struct that implements L1BatchCommit…
…ter depending on the VALIDIUM_MODE env value
Configuration menu - View commit details
-
Copy full SHA for ed898c1 - Browse repository at this point
Copy the full SHA ed898c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b048893 - Browse repository at this point
Copy the full SHA b048893View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ca23ca - Browse repository at this point
Copy the full SHA 6ca23caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 908097d - Browse repository at this point
Copy the full SHA 908097dView commit details -
Merge branch 'validium_mode_new_fee_model_final' of github.com:lambda…
…class/zksync-era into feat_validium_pubdata_abstraction
Configuration menu - View commit details
-
Copy full SHA for dedcf24 - Browse repository at this point
Copy the full SHA dedcf24View commit details
Commits on Jan 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6009297 - Browse repository at this point
Copy the full SHA 6009297View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80d4b03 - Browse repository at this point
Copy the full SHA 80d4b03View commit details -
Configuration menu - View commit details
-
Copy full SHA for b791161 - Browse repository at this point
Copy the full SHA b791161View commit details
Commits on Feb 2, 2024
-
feat: Rename Validium abstraction and implementors (#92)
* Rename Validium pubdata abstraction and implementors * Rename struct fields and variables * feat: Abstract commit data generator initialization (#94) * Add L1BatchCommitDataGeneratorMode to StateKeeperConfig * Initialize L1BatchCommitter depending on the StateKeeperConfig * Fix bad merge
Configuration menu - View commit details
-
Copy full SHA for b4821e1 - Browse repository at this point
Copy the full SHA b4821e1View commit details -
feat: Not charging for pubdata (#98)
* add variable to .toml * zk fmt
Configuration menu - View commit details
-
Copy full SHA for 6d08fc4 - Browse repository at this point
Copy the full SHA 6d08fc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f9ac9c - Browse repository at this point
Copy the full SHA 6f9ac9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f4cffe - Browse repository at this point
Copy the full SHA 0f4cffeView commit details -
Merge branch 'main' of github.com:lambdaclass/zksync-era into validiu…
…m_mode_new_fee_model_final
Configuration menu - View commit details
-
Copy full SHA for e34dcfa - Browse repository at this point
Copy the full SHA e34dcfaView commit details -
Merge branch 'validium_mode_new_fee_model_final' of github.com:lambda…
…class/zksync-era into validium_mode_new_fee_model_final
Configuration menu - View commit details
-
Copy full SHA for 5ec41b2 - Browse repository at this point
Copy the full SHA 5ec41b2View commit details
Commits on Feb 3, 2024
-
Merge branch 'main' of github.com:lambdaclass/zksync-era into feat_va…
…lidium_pubdata_abstraction
Configuration menu - View commit details
-
Copy full SHA for 0ce5616 - Browse repository at this point
Copy the full SHA 0ce5616View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebca913 - Browse repository at this point
Copy the full SHA ebca913View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f9eb9f - Browse repository at this point
Copy the full SHA 6f9eb9fView commit details
Commits on Feb 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c7bd24a - Browse repository at this point
Copy the full SHA c7bd24aView commit details
Commits on Feb 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e75d4eb - Browse repository at this point
Copy the full SHA e75d4ebView commit details -
Merge branch 'validium_mode_new_fee_model_final' of github.com:lambda…
…class/zksync-era into feat_validium_pubdata_abstraction
Configuration menu - View commit details
-
Copy full SHA for f5222a6 - Browse repository at this point
Copy the full SHA f5222a6View commit details
Commits on Feb 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f7df89e - Browse repository at this point
Copy the full SHA f7df89eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8f5283 - Browse repository at this point
Copy the full SHA f8f5283View commit details -
Configuration menu - View commit details
-
Copy full SHA for 584b4c9 - Browse repository at this point
Copy the full SHA 584b4c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83df096 - Browse repository at this point
Copy the full SHA 83df096View commit details -
Configuration menu - View commit details
-
Copy full SHA for 706bc44 - Browse repository at this point
Copy the full SHA 706bc44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 855c727 - Browse repository at this point
Copy the full SHA 855c727View commit details -
Merge branch 'feat_validium_pubdata_abstraction' of github.com:lambda…
…class/zksync-era into feat_validium_pubdata_abstraction
Configuration menu - View commit details
-
Copy full SHA for 6327106 - Browse repository at this point
Copy the full SHA 6327106View commit details
Commits on Feb 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eae85d1 - Browse repository at this point
Copy the full SHA eae85d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 502f3e8 - Browse repository at this point
Copy the full SHA 502f3e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4de515 - Browse repository at this point
Copy the full SHA c4de515View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73a82a2 - Browse repository at this point
Copy the full SHA 73a82a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12ba1b7 - Browse repository at this point
Copy the full SHA 12ba1b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85ca136 - Browse repository at this point
Copy the full SHA 85ca136View commit details
Commits on Feb 15, 2024
-
feat: adapt
consistency_checker
tests for running both in Validium ……mode and Rollup mode (#121) * Add example: build_commit_tx_input_data_is_correct (fails) * Abstract normal_checker_function test * Abstract checker_processes_pre_boojum_batches * Abstract checker_functions_after_snapshot_recovery test * Abstract checker_functions_after_snapshot_recovery test * Remove unnecessary auxiliar function * Fix all the failing tests * Use test_helpers module * Remove ValidiumModeL1BatchCommitDataGenerator fix * Add bytes pubdata with 0 value for the encoding (#136)
Configuration menu - View commit details
-
Copy full SHA for d31d1a6 - Browse repository at this point
Copy the full SHA d31d1a6View commit details -
fix: update function visibility in
consistency_checker
tests (#137)* Add example: build_commit_tx_input_data_is_correct (fails) * Abstract normal_checker_function test * Abstract checker_processes_pre_boojum_batches * Abstract checker_functions_after_snapshot_recovery test * Abstract checker_functions_after_snapshot_recovery test * Remove unnecessary auxiliar function * Fix all the failing tests * Use test_helpers module * Remove ValidiumModeL1BatchCommitDataGenerator fix * Add bytes pubdata with 0 value for the encoding (#136) * Fix unnecessary pub
Configuration menu - View commit details
-
Copy full SHA for b693293 - Browse repository at this point
Copy the full SHA b693293View commit details -
feat:
--validium-mode
flag sets Validium config automatically (#138)* abstract setup mode method * remove blank line * add config mode in all init methods * update log * Fix some comments (#99) * Fix eth_sender value * Restore original config file and omit commented values * Format * abstract methods and constants * remove async * remove unnecessary async * change constant value * add cosntant * fix: test new vars (#114) * Update new variables between modes * Format * Fix toml format * Fix remove line * fix bug where dev.env is not overwritten * Revert "fix bug where dev.env is not overwritten" This reverts commit 051f173. * fix bug in dev.env load * Fix updateConfigFile * Fix initialization * Remove repeated constant definitions * Remove internal enforced l1 gas price set --------- Co-authored-by: toni-calvin <antonio.calvin@lambdaclass.com> Co-authored-by: Jordi <146965181+jordibonet-lambdaclass@users.noreply.github.com> Co-authored-by: Jordi <jordi.bonet.valiente@lambdaclass.com> Co-authored-by: Joaquin Carletti <joaquin.carletti@lambdaclass.com>
Configuration menu - View commit details
-
Copy full SHA for bdb26c3 - Browse repository at this point
Copy the full SHA bdb26c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 916c56b - Browse repository at this point
Copy the full SHA 916c56bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7391c21 - Browse repository at this point
Copy the full SHA 7391c21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9694281 - Browse repository at this point
Copy the full SHA 9694281View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cd2be9 - Browse repository at this point
Copy the full SHA 7cd2be9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d38dc48 - Browse repository at this point
Copy the full SHA d38dc48View commit details -
feat: adapt
eth_sender
tests for running both in Validium mode and ……Rollup mode (#120) * abstract confirm many test * abstract resend_each_block_Tst * abstract dont_resend_already_mined test * abstract three_scenarios_test * abstract failed_eth_tx test * add correct_order_for_confirmations and skipped_l1_batch_at_the_start abstraction test * add skipped_l1_batch_in_the_middle test abstraction * add test_parse_multicall_data abstraction * add get_multicall_data abstraction * fix failing tests * change base branch * add return type in test function * separate tests using test helper * update test methods to accept l1_commit_data_generator * pass zk lint --check
Configuration menu - View commit details
-
Copy full SHA for fc03061 - Browse repository at this point
Copy the full SHA fc03061View commit details
Commits on Feb 16, 2024
-
feat: adapt
zksync_env_config::eth_sender
tests for running both in…… Validium mode and Rollup mode (#142) * add validium env test * abstract from_env method
Configuration menu - View commit details
-
Copy full SHA for 08fa235 - Browse repository at this point
Copy the full SHA 08fa235View commit details -
feat: adapt
zksync_env_config::chain
tests for running both in Vali……dium mode and Rollup mode (#143) * Adapt state keeper test for validium configuration * Rename variables * Fix format * Optimize code * Format * Abstract the repeated logic * Abstract the repeated logic correctly * Remove unnecessary reference
Configuration menu - View commit details
-
Copy full SHA for d3fa3b4 - Browse repository at this point
Copy the full SHA d3fa3b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34f9f37 - Browse repository at this point
Copy the full SHA 34f9f37View commit details
Commits on Feb 19, 2024
-
move l1_batch_commit_data_generator to DataSizeCriterion so that it d…
…oesn't pollute L1BatchPublishCriterion interface (#151)
Configuration menu - View commit details
-
Copy full SHA for 776f935 - Browse repository at this point
Copy the full SHA 776f935View commit details -
add parameters to the ConsistencyChecker structure itself, rather tha…
…n to the run() method (#152)
Configuration menu - View commit details
-
Copy full SHA for 7f52a8d - Browse repository at this point
Copy the full SHA 7f52a8dView commit details -
Merge branch 'main' of github.com:lambdaclass/zksync-era into feat_va…
…lidium_pubdata_abstraction
Configuration menu - View commit details
-
Copy full SHA for 95c08a5 - Browse repository at this point
Copy the full SHA 95c08a5View commit details -
Revert "Merge branch 'main' of github.com:lambdaclass/zksync-era into…
Configuration menu - View commit details
-
Copy full SHA for 9a26760 - Browse repository at this point
Copy the full SHA 9a26760View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3028625 - Browse repository at this point
Copy the full SHA 3028625View commit details -
Configuration menu - View commit details
-
Copy full SHA for b07dc55 - Browse repository at this point
Copy the full SHA b07dc55View commit details -
Merge branch 'validium_mode_new_fee_model_final' of github.com:Lambda…
…Class/zksync-era into feat_validium_pubdata_abstraction
Configuration menu - View commit details
-
Copy full SHA for c930b54 - Browse repository at this point
Copy the full SHA c930b54View commit details
Commits on Feb 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 82efd79 - Browse repository at this point
Copy the full SHA 82efd79View commit details
Commits on Feb 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c4b6cde - Browse repository at this point
Copy the full SHA c4b6cdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a5407e - Browse repository at this point
Copy the full SHA 0a5407eView commit details
Commits on Feb 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ec0af17 - Browse repository at this point
Copy the full SHA ec0af17View commit details