Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validium mode abstraction #1015

Closed

Commits on Jan 25, 2024

  1. Add Validium mode example

    ilitteri committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f6c99ac View commit details
    Browse the repository at this point in the history
  2. Use Ethereum's L1 gas price

    ilitteri committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    9736d97 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2d9c427 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    24cd669 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    af06969 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. - add basic abstraction for DataProvider for eth_tx_aggregator

    - Needs to fix errors in tests related to the new Generic Data Type
    mationorato committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    982d638 View commit details
    Browse the repository at this point in the history
  2. run zk fmt

    mationorato committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    d9548c8 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. revert yarn.lock (#77)

    toni-calvin authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    bf32093 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Configuration menu
    Copy the full SHA
    90e06d7 View commit details
    Browse the repository at this point in the history
  2. Remove l1_commit_data, l1_commit_data_size and construct_pubdata meth…

    …ods from L1BatchWithMetadata as they're now part of the L1BatchCommitter trait and utils in the case of construct_pubdata
    ilitteri committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    b6ba50c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7f6d849 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3c714b9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    748fb83 View commit details
    Browse the repository at this point in the history
  6. Add l1_batch_committer field to Aggregator struct for later L1BatchCo…

    …mmitOperation construction and DatasizeCriterion::last_l1_batch_to_publish usage
    ilitteri committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    6467073 View commit details
    Browse the repository at this point in the history
  7. Add l1_batch_committer as a L1BatchPublishCriterion::last_l1_batch_to…

    …_publish parameter (only used by DataSizeCriterion)
    ilitteri committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    5abeb45 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d8027bf View commit details
    Browse the repository at this point in the history
  9. Fix eth_sender tests

    ilitteri committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    bb3c7d1 View commit details
    Browse the repository at this point in the history
  10. Update consistency_checker module where needed for using L1BatchCommi…

    …tter::l1_commit_data function
    ilitteri committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7f9ad63 View commit details
    Browse the repository at this point in the history
  11. Update external_node module where needed for using L1BatchCommitter::…

    …l1_commit_data function
    ilitteri committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    fc2245f View commit details
    Browse the repository at this point in the history
  12. Initialize the Aggregator with a struct that implements L1BatchCommit…

    …ter depending on the VALIDIUM_MODE env value
    ilitteri committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    ed898c1 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    b048893 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    6ca23ca View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    908097d View commit details
    Browse the repository at this point in the history
  16. Merge branch 'validium_mode_new_fee_model_final' of github.com:lambda…

    …class/zksync-era into feat_validium_pubdata_abstraction
    ilitteri committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    dedcf24 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Configuration menu
    Copy the full SHA
    6009297 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    80d4b03 View commit details
    Browse the repository at this point in the history
  3. Fix init.ts

    ilitteri committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    b791161 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. feat: Rename Validium abstraction and implementors (#92)

    * Rename Validium pubdata abstraction and implementors
    
    * Rename struct fields and variables
    
    * feat: Abstract commit data generator initialization (#94)
    
    * Add L1BatchCommitDataGeneratorMode to StateKeeperConfig
    
    * Initialize L1BatchCommitter depending on the StateKeeperConfig
    
    * Fix bad merge
    ilitteri authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    b4821e1 View commit details
    Browse the repository at this point in the history
  2. feat: Not charging for pubdata (#98)

    * add variable to .toml
    
    * zk fmt
    ColoCarletti authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    6d08fc4 View commit details
    Browse the repository at this point in the history
  3. Remove debug prints

    ilitteri committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    6f9ac9c View commit details
    Browse the repository at this point in the history
  4. Add tracing::debug logs

    ilitteri committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    0f4cffe View commit details
    Browse the repository at this point in the history
  5. Merge branch 'main' of github.com:lambdaclass/zksync-era into validiu…

    …m_mode_new_fee_model_final
    ilitteri committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    e34dcfa View commit details
    Browse the repository at this point in the history
  6. Merge branch 'validium_mode_new_fee_model_final' of github.com:lambda…

    …class/zksync-era into validium_mode_new_fee_model_final
    ilitteri committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    5ec41b2 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Merge branch 'main' of github.com:lambdaclass/zksync-era into feat_va…

    …lidium_pubdata_abstraction
    ilitteri committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    0ce5616 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ebca913 View commit details
    Browse the repository at this point in the history
  3. Remove unused trait method

    ilitteri committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    6f9eb9f View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Configuration menu
    Copy the full SHA
    c7bd24a View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Configuration menu
    Copy the full SHA
    e75d4eb View commit details
    Browse the repository at this point in the history
  2. Merge branch 'validium_mode_new_fee_model_final' of github.com:lambda…

    …class/zksync-era into feat_validium_pubdata_abstraction
    ilitteri committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f5222a6 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. apply spellcheck

    mationorato committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    f7df89e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f8f5283 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    584b4c9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    83df096 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    706bc44 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    855c727 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'feat_validium_pubdata_abstraction' of github.com:lambda…

    …class/zksync-era into feat_validium_pubdata_abstraction
    lferrigno committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    6327106 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. fmt fix

    lferrigno committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    eae85d1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    502f3e8 View commit details
    Browse the repository at this point in the history
  3. fix core linter

    lferrigno committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    c4de515 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    73a82a2 View commit details
    Browse the repository at this point in the history
  5. Fix eth_sender from_env test

    ilitteri committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    12ba1b7 View commit details
    Browse the repository at this point in the history
  6. Remove debug config

    ilitteri committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    85ca136 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. feat: adapt consistency_checker tests for running both in Validium …

    …mode and Rollup mode (#121)
    
    * Add example: build_commit_tx_input_data_is_correct (fails)
    
    * Abstract normal_checker_function test
    
    * Abstract checker_processes_pre_boojum_batches
    
    * Abstract checker_functions_after_snapshot_recovery test
    
    * Abstract checker_functions_after_snapshot_recovery test
    
    * Remove unnecessary auxiliar function
    
    * Fix all the failing tests
    
    * Use test_helpers module
    
    * Remove ValidiumModeL1BatchCommitDataGenerator fix
    
    * Add bytes pubdata with 0 value for the encoding (#136)
    jordibonet-lambdaclass authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d31d1a6 View commit details
    Browse the repository at this point in the history
  2. fix: update function visibility in consistency_checker tests (#137)

    * Add example: build_commit_tx_input_data_is_correct (fails)
    
    * Abstract normal_checker_function test
    
    * Abstract checker_processes_pre_boojum_batches
    
    * Abstract checker_functions_after_snapshot_recovery test
    
    * Abstract checker_functions_after_snapshot_recovery test
    
    * Remove unnecessary auxiliar function
    
    * Fix all the failing tests
    
    * Use test_helpers module
    
    * Remove ValidiumModeL1BatchCommitDataGenerator fix
    
    * Add bytes pubdata with 0 value for the encoding (#136)
    
    * Fix unnecessary pub
    jordibonet-lambdaclass authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    b693293 View commit details
    Browse the repository at this point in the history
  3. feat: --validium-mode flag sets Validium config automatically (#138)

    * abstract setup mode method
    
    * remove blank line
    
    * add config mode in all init methods
    
    * update log
    
    * Fix some comments (#99)
    
    * Fix eth_sender value
    
    * Restore original config file and omit commented values
    
    * Format
    
    * abstract methods and constants
    
    * remove async
    
    * remove unnecessary async
    
    * change constant value
    
    * add cosntant
    
    * fix: test new vars (#114)
    
    * Update new variables between modes
    
    * Format
    
    * Fix toml format
    
    * Fix remove line
    
    * fix bug where dev.env is not overwritten
    
    * Revert "fix bug where dev.env is not overwritten"
    
    This reverts commit 051f173.
    
    * fix bug in dev.env load
    
    * Fix updateConfigFile
    
    * Fix initialization
    
    * Remove repeated constant definitions
    
    * Remove internal enforced l1 gas price set
    
    ---------
    
    Co-authored-by: toni-calvin <antonio.calvin@lambdaclass.com>
    Co-authored-by: Jordi <146965181+jordibonet-lambdaclass@users.noreply.github.com>
    Co-authored-by: Jordi <jordi.bonet.valiente@lambdaclass.com>
    Co-authored-by: Joaquin Carletti <joaquin.carletti@lambdaclass.com>
    5 people authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    bdb26c3 View commit details
    Browse the repository at this point in the history
  4. zk fmt

    ilitteri committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    916c56b View commit details
    Browse the repository at this point in the history
  5. Fix protobuf unit tests

    ilitteri committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    7391c21 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9694281 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7cd2be9 View commit details
    Browse the repository at this point in the history
  8. zk lint

    ilitteri committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d38dc48 View commit details
    Browse the repository at this point in the history
  9. feat: adapt eth_sender tests for running both in Validium mode and …

    …Rollup mode (#120)
    
    * abstract confirm many test
    
    * abstract resend_each_block_Tst
    
    * abstract dont_resend_already_mined test
    
    * abstract three_scenarios_test
    
    * abstract failed_eth_tx test
    
    * add correct_order_for_confirmations and skipped_l1_batch_at_the_start abstraction test
    
    * add skipped_l1_batch_in_the_middle test abstraction
    
    * add test_parse_multicall_data abstraction
    
    * add get_multicall_data abstraction
    
    * fix failing tests
    
    * change base branch
    
    * add return type in test function
    
    * separate tests using test helper
    
    * update test methods to accept l1_commit_data_generator
    
    * pass zk lint --check
    toni-calvin authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    fc03061 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. feat: adapt zksync_env_config::eth_sender tests for running both in…

    … Validium mode and Rollup mode (#142)
    
    * add validium env test
    
    * abstract from_env method
    toni-calvin authored Feb 16, 2024
    Configuration menu
    Copy the full SHA
    08fa235 View commit details
    Browse the repository at this point in the history
  2. feat: adapt zksync_env_config::chain tests for running both in Vali…

    …dium mode and Rollup mode (#143)
    
    * Adapt state keeper test for validium configuration
    
    * Rename variables
    
    * Fix format
    
    * Optimize code
    
    * Format
    
    * Abstract the repeated logic
    
    * Abstract the repeated logic correctly
    
    * Remove unnecessary reference
    jordibonet-lambdaclass authored Feb 16, 2024
    Configuration menu
    Copy the full SHA
    d3fa3b4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    34f9f37 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. move l1_batch_commit_data_generator to DataSizeCriterion so that it d…

    …oesn't pollute L1BatchPublishCriterion interface (#151)
    ilitteri authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    776f935 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7f52a8d View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' of github.com:lambdaclass/zksync-era into feat_va…

    …lidium_pubdata_abstraction
    ilitteri committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    95c08a5 View commit details
    Browse the repository at this point in the history
  4. Revert "Merge branch 'main' of github.com:lambdaclass/zksync-era into…

    … feat_validium_pubdata_abstraction"
    
    This reverts commit 95c08a5, reversing
    changes made to 7f52a8d.
    ilitteri committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9a26760 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3028625 View commit details
    Browse the repository at this point in the history
  6. Merge main

    ilitteri committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b07dc55 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'validium_mode_new_fee_model_final' of github.com:Lambda…

    …Class/zksync-era into feat_validium_pubdata_abstraction
    ilitteri committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    c930b54 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Configuration menu
    Copy the full SHA
    82efd79 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Remove TODOs comments

    jorbush committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    c4b6cde View commit details
    Browse the repository at this point in the history
  2. Revert "Remove TODOs comments"

    This reverts commit c4b6cde.
    jorbush committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    0a5407e View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Configuration menu
    Copy the full SHA
    ec0af17 View commit details
    Browse the repository at this point in the history