Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete unused config files in validium pubdata abstraction #113

Merged

Conversation

toni-calvin
Copy link

@toni-calvin toni-calvin commented Feb 8, 2024

Issues

Merging this PR fixes: #111, #108, #109 and #110

What ❔

Removing era-contracts-lambda submodule as it is no longer necessary. Also removing zksync-config crate from l1-contract-interface as it is not used anymore.
There is also a sql file created in the initialisation that should not be tracked.
Finally there is a nit where empty structs don't need braces so it removes them.

Why ❔

Removing unnecessary imports and repository files.

Description ❕

This pull request aims to streamline the repository by removing the now unnecessary era-contracts-lambda submodule and the zksync-config crate from l1-contract-interface. These changes have been made to clean up the codebase, removing unused dependencies and files.

Expected Behavior ❗

After applying these changes, running the following commands should complete successfully without any issues:

zk
zk clean --all
zk init --validium-mode
zk server

@toni-calvin toni-calvin linked an issue Feb 8, 2024 that may be closed by this pull request
Copy link
Collaborator

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For next time, even if the changes are minimal, every issue should have its own PR (this is not mandatory btw, it depends on the tasks, in this case it applies)

@ilitteri ilitteri merged commit e75d4eb into feat_validium_pubdata_abstraction Feb 8, 2024
8 of 12 checks passed
@ilitteri ilitteri deleted the delete-unused-validium-config branch February 8, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment