-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adapt zksync_env_config::chain
tests for running both in Validium mode and Rollup mode
#143
feat: adapt zksync_env_config::chain
tests for running both in Validium mode and Rollup mode
#143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works fine. Let's refactor the code a little bit. I propose making expected_state_keeper_config
generic for l1_batch_commit_data_generator_mode
, and then we can either split the state_keeper_from_env
test into a Validium and a Rollup one or just abstract the repeated logic into another helper function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d3fa3b4
into
feat_validium_pubdata_abstraction
What ❔
Update the
zksync_env_config::chain
test ofstate_keeper_from_env
to take into account the Rollup and Validium mode settings and check that both settings are modified correctly.Checklist
Changes
I have separated the
expected_state_keeper_config()
into two functions to manage theStateKeeperConfig
for both modes and updatedstate_keeper_from_env()
test to compare the new mockup configuration and theStateKeeperConfig
of the Validium mode.Check
zksync_env_config::chain
tests