Add a test for mode changes correctly applying to users. #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures seem related to concurrency, again. |
AndrewFerr
requested changes
Jun 6, 2023
| @@ -226,7 +226,7 @@ export class RoomAccessSyncer { | |||
| ); | |||
| if (matrixRooms.length === 0) { | |||
| req.log.info("No mapped matrix rooms for IRC channel %s", channel); | |||
| return; | |||
| return BridgeRequestErr.ERR_NOT_MAPPED; | |||
There was a problem hiding this comment.
Given the pattern of returning undefined vs an error enum appears elsewhere, I'm confident that this works, but where are these enum values handled?
There was a problem hiding this comment.
It's ultimately handled in
matrix-appservice-irc/src/bridge/IrcBridge.ts
Line 889 in 3e2dabe
AndrewFerr
approved these changes
Jun 8, 2023
Half-Shot
added a commit
that referenced
this pull request
Jun 9, 2023
* Add powerlevel e2e test * Log failures properly * Log when we don't know a mode value * Set sensible mode defaults * Remove mistaken log line * Remove consistent return lint rule * changelog * update changelog * Improve userPrefixes check * Catch failures to kill redis * Don't call quit twice * Remove duplicate test * Fix unit test * Disable passkey enc * sneaky fix to stop logging pong timeouts erronously * Remove comment * Drop console line * Review tweaks * Fix changelog * Add a loop to check all power levels * Add ability to check for the right PL * Don't wait for charlie's matrix membership
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as adding some improved logging around the area.