Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for mode changes correctly applying to users. #1732
Add a test for mode changes correctly applying to users. #1732
Changes from all commits
3e34b35
c274c46
97eb228
58d006f
67d28c3
e492e51
2ba8027
02c6f63
9f841ce
c14df2e
3785fb2
876f356
4a0b9e7
f3d949d
7213877
3e2dabe
7d95d7d
6b67c8d
4b7c818
93bda41
d2f236c
7a1e0a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the pattern of returning undefined vs an error enum appears elsewhere, I'm confident that this works, but where are these enum values handled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ultimately handled in
matrix-appservice-irc/src/bridge/IrcBridge.ts
Line 889 in 3e2dabe